Re: [patch 3/3] s390: dasd extended error reporting module.

[Christoph Hellwig <hch@infradead.org>]

On Fri, Dec 16, 2005 at 02:29:53PM +0100, Martin Schwidefsky wrote:
> From: Stefan Weinhuber <wein@de.ibm.com>
> 
> [patch 3/3] s390: dasd extended error reporting module.
> 
> The DASD extended error reporting is a facility that allows to
> get detailed information about certain problems in the DASD I/O.
> This information can be used to implement fail-over applications
> that can recover these problems.
> 
> Signed-off-by: Stefan Weinhuber <wein@de.ibm.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> 
> ---
> 
>  arch/s390/kernel/compat_ioctl.c    |    2 
>  drivers/s390/block/Kconfig         |   14 
>  drivers/s390/block/Makefile        |    2 
>  drivers/s390/block/dasd.c          |   76 ++
>  drivers/s390/block/dasd_3990_erp.c |    5 
>  drivers/s390/block/dasd_eckd.h     |    3 
>  drivers/s390/block/dasd_eer.c      | 1091 +++++++++++++++++++++++++++++++++++++
>  drivers/s390/block/dasd_int.h      |   37 +
>  include/asm-s390/dasd.h            |   15 
>  9 files changed, 1237 insertions(+), 8 deletions(-)
> 
> diff -urpN linux-2.6/arch/s390/kernel/compat_ioctl.c linux-2.6-patched/arch/s390/kernel/compat_ioctl.c
> --- linux-2.6/arch/s390/kernel/compat_ioctl.c	2005-12-16 10:56:42.000000000 +0100
> +++ linux-2.6-patched/arch/s390/kernel/compat_ioctl.c	2005-12-16 10:57:24.000000000 +0100
> @@ -63,6 +63,8 @@ COMPATIBLE_IOCTL(BIODASDSATTR)
>  COMPATIBLE_IOCTL(BIODASDCMFENABLE)
>  COMPATIBLE_IOCTL(BIODASDCMFDISABLE)
>  COMPATIBLE_IOCTL(BIODASDREADALLCMB)
> +COMPATIBLE_IOCTL(BIODASDEERSET)
> +COMPATIBLE_IOCTL(BIODASDEERGET)

Nack, now new ioctls in compat_ioctl.c, please.  In fact that file is
gone in -mm, so please submit this patch ontop of the -mm tree.


And is there a chance for a better interface than the notifier lists?
The code looks rather awkward because of it.