From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
akpm@osdl.org, wein@de.ibm.com, Horst.Hummel@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch 3/3] s390: dasd extended error reporting module.
Date: Fri, 16 Dec 2005 14:35:40 +0000 [thread overview]
Message-ID: <20051216143540.GA25097@infradead.org> (raw)
In-Reply-To: <1134743589.5495.16.camel@localhost.localdomain>
On Fri, Dec 16, 2005 at 03:33:09PM +0100, Martin Schwidefsky wrote:
> On a side not, Arnd just told my about the bug in the dasd_eckd
> discipline. We need to check the discipline in the eckd specific ioctls.
> I'll tell the appropriate people (well in fact I already did because
> they are on CC:). As for adding a per discipline .ioctl function, that
> won't work because of cmb and eer. These modules do not implement a
> discipline but still have to add ioctls.
cmd shouldn't be a module of it's own (see patch just sent), and the
same is true of this module. Functionality that doesn't have it's own
fundamental objects to operate on should be separate modules. If you
use modules ala dlopen()ed .so libraries in userspace you will always
get code that's a piece of junk and full of bugs.
prev parent reply other threads:[~2005-12-16 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 13:29 [patch 3/3] s390: dasd extended error reporting module Martin Schwidefsky
2005-12-16 13:47 ` Christoph Hellwig
2005-12-16 14:33 ` Martin Schwidefsky
2005-12-16 14:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051216143540.GA25097@infradead.org \
--to=hch@infradead.org \
--cc=Horst.Hummel@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=wein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox