From: Adrian Bunk <bunk@stusta.de>
To: Gerhard Mack <gmack@innerfire.net>,
wli@holomorphy.com, davem@davemloft.net, ecd@brainaid.de,
jj@sunsite.ms.mff.cuni.cz, anton@samba.org
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: [2.6 patch] on sparc{,64}, RTC must depend on PCI
Date: Sat, 17 Dec 2005 15:10:49 +0100 [thread overview]
Message-ID: <20051217141049.GP23349@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0512161908460.20531@innerfire.net>
On Fri, Dec 16, 2005 at 07:10:05PM -0500, Gerhard Mack wrote:
>
> I always forget that for some reason.
> If I disable CONFIG_RTC it compiles cleanly.
That's expected since this is the driver that breaks the build.
The patch below adds the dependency of CONFIG_RTC on CONFIG_PCI on the
sparc architecture.
> Gerhard
cu
Adrian
BTW: @sparc maintainers:
Is there any reason against introducing a SPARC Kconfig symbol
that is set on both the sparc and sparc64 architectures?
<-- snip -->
On sparc and sparc64, the rtc driver doesn't compile with PCI support
disabled.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.14.4/drivers/char/Kconfig.old 2005-12-17 15:03:06.000000000 +0100
+++ linux-2.6.14.4/drivers/char/Kconfig 2005-12-17 15:03:33.000000000 +0100
@@ -687,7 +687,7 @@
config RTC
tristate "Enhanced Real Time Clock Support"
- depends on !PPC32 && !PARISC && !IA64 && !M68K
+ depends on !PPC32 && !PARISC && !IA64 && !M68K && (!(SPARC32 || SPARC64) || PCI)
---help---
If you say Y here and create a character special file /dev/rtc with
major number 10 and minor number 135 using mknod ("man mknod"), you
next prev parent reply other threads:[~2005-12-17 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 13:33 linux 2.6.14.4 sparc compile problem Gerhard Mack
2005-12-16 22:21 ` Adrian Bunk
2005-12-17 0:10 ` Gerhard Mack
2005-12-17 14:10 ` Adrian Bunk [this message]
2005-12-19 22:52 ` [2.6 patch] on sparc{,64}, RTC must depend on PCI David S. Miller
2005-12-23 2:15 ` [2.6 patch] introduce a SPARC Kconfig symbol Adrian Bunk
2005-12-23 5:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051217141049.GP23349@stusta.de \
--to=bunk@stusta.de \
--cc=anton@samba.org \
--cc=davem@davemloft.net \
--cc=ecd@brainaid.de \
--cc=gmack@innerfire.net \
--cc=jj@sunsite.ms.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox