* remove CONFIG_UID16
@ 2005-12-17 4:44 Adrian Bunk
2005-12-17 13:18 ` Christoph Hellwig
2005-12-17 19:54 ` Matt Mackall
0 siblings, 2 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-12-17 4:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Matt Mackall
It seems noone noticed that CONFIG_UID16 was accidentially always
disabled in the latest -mm kernels.
Is there any reason against removing it completely?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: remove CONFIG_UID16
2005-12-17 4:44 remove CONFIG_UID16 Adrian Bunk
@ 2005-12-17 13:18 ` Christoph Hellwig
2005-12-17 18:38 ` Adrian Bunk
2005-12-17 19:54 ` Matt Mackall
1 sibling, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2005-12-17 13:18 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, Matt Mackall
On Sat, Dec 17, 2005 at 05:44:10AM +0100, Adrian Bunk wrote:
> It seems noone noticed that CONFIG_UID16 was accidentially always
> disabled in the latest -mm kernels.
>
> Is there any reason against removing it completely?
Yes, it breaks backwards-compatilbity for not even that old binaries.
There's not way we're ever going to remove it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: remove CONFIG_UID16
2005-12-17 13:18 ` Christoph Hellwig
@ 2005-12-17 18:38 ` Adrian Bunk
2005-12-22 22:12 ` Bill Davidsen
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-12-17 18:38 UTC (permalink / raw)
To: Christoph Hellwig, linux-kernel, Matt Mackall
On Sat, Dec 17, 2005 at 01:18:07PM +0000, Christoph Hellwig wrote:
> On Sat, Dec 17, 2005 at 05:44:10AM +0100, Adrian Bunk wrote:
> > It seems noone noticed that CONFIG_UID16 was accidentially always
> > disabled in the latest -mm kernels.
> >
> > Is there any reason against removing it completely?
>
> Yes, it breaks backwards-compatilbity for not even that old binaries.
>
> There's not way we're ever going to remove it.
You are right.
Sorry, this was a dumb idea
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: remove CONFIG_UID16
2005-12-17 4:44 remove CONFIG_UID16 Adrian Bunk
2005-12-17 13:18 ` Christoph Hellwig
@ 2005-12-17 19:54 ` Matt Mackall
2005-12-17 21:40 ` [-mm patch] re-enable UID16 for !EMBEDDED Adrian Bunk
1 sibling, 1 reply; 6+ messages in thread
From: Matt Mackall @ 2005-12-17 19:54 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sat, Dec 17, 2005 at 05:44:10AM +0100, Adrian Bunk wrote:
> It seems noone noticed that CONFIG_UID16 was accidentially always
> disabled in the latest -mm kernels.
Hmm, did I break it?
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [-mm patch] re-enable UID16 for !EMBEDDED
2005-12-17 19:54 ` Matt Mackall
@ 2005-12-17 21:40 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-12-17 21:40 UTC (permalink / raw)
To: Matt Mackall, Andrew Morton; +Cc: linux-kernel
On Sat, Dec 17, 2005 at 11:54:48AM -0800, Matt Mackall wrote:
> On Sat, Dec 17, 2005 at 05:44:10AM +0100, Adrian Bunk wrote:
> > It seems noone noticed that CONFIG_UID16 was accidentially always
> > disabled in the latest -mm kernels.
>
> Hmm, did I break it?
Yes, patch below.
cu
Adrian
<-- snip -->
UID16 was accidentially disabled for !EMBEDDED.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-rc5-mm3-full/init/Kconfig.old 2005-12-17 19:55:58.000000000 +0100
+++ linux-2.6.15-rc5-mm3-full/init/Kconfig 2005-12-17 19:56:12.000000000 +0100
@@ -337,10 +337,11 @@
config UID16
bool "Enable 16-bit UID system calls" if EMBEDDED
depends !ALPHA && !PPC && !PPC64 && !PARISC && !V850 && !ARCH_S390X
depends !X86_64 || IA32_EMULATION
depends !SPARC64 || SPARC32_COMPAT
+ default y
help
This enables the legacy 16-bit UID syscall wrappers.
config CC_OPTIMIZE_FOR_SIZE
bool "Optimize for size"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: remove CONFIG_UID16
2005-12-17 18:38 ` Adrian Bunk
@ 2005-12-22 22:12 ` Bill Davidsen
0 siblings, 0 replies; 6+ messages in thread
From: Bill Davidsen @ 2005-12-22 22:12 UTC (permalink / raw)
To: Adrian Bunk, Linux Kernel Mailing List
Adrian Bunk wrote:
> On Sat, Dec 17, 2005 at 01:18:07PM +0000, Christoph Hellwig wrote:
>
>>On Sat, Dec 17, 2005 at 05:44:10AM +0100, Adrian Bunk wrote:
>>
>>>It seems noone noticed that CONFIG_UID16 was accidentially always
>>>disabled in the latest -mm kernels.
>>>
>>>Is there any reason against removing it completely?
>>
>>Yes, it breaks backwards-compatilbity for not even that old binaries.
>>
>>There's not way we're ever going to remove it.
>
>
> You are right.
>
> Sorry, this was a dumb idea
The question is, did you prove that (a) the people who need it are smart
enough to set it, or (b) the people who need it are not testing -mm kernels.
--
-bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
last possible moment - but no longer" -me
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-12-22 22:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-17 4:44 remove CONFIG_UID16 Adrian Bunk
2005-12-17 13:18 ` Christoph Hellwig
2005-12-17 18:38 ` Adrian Bunk
2005-12-22 22:12 ` Bill Davidsen
2005-12-17 19:54 ` Matt Mackall
2005-12-17 21:40 ` [-mm patch] re-enable UID16 for !EMBEDDED Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox