Re: [PATCH 07/13] [RFC] ipath core misc files

Andrew Morton
2005-12-18T03:10:16Z

Robert Walsh <rjwalsh@pathscale.com> wrote:
>
> > > +int ipath_mlock(unsigned long start_page, size_t num_pages, struct page **p)
> > OK. It's perhaps not a very well named function.
>
> Really? Suggestion for a better name?
>

ipath_get_user_pages() would cause the least surprise.

> > > + }
> > > + vm->vm_flags |= VM_SHM | VM_LOCKED;
> > > +
> > > + return 0;
> > > +}
> >
> > I don't think we want to be setting the user's VMA's vm_flags in this
> > manner. This is purely to retain the physical page across fork?
>
> I didn't write this bit of the driver, but I believe this is the case.
> Is there a better way of doing this?

This stuff has been churning a bit lately. I've drawn Hugh Dickins's
attention to the patch - he'd have a better handle on what the best
approach would be.