Re: [PATCH 00/13] [RFC] IB: PathScale InfiniPath driver

Christoph Hellwig
2005-12-17T13:16:16Z

On Fri, Dec 16, 2005 at 03:48:54PM -0800, Roland Dreier wrote:
> having sysctls that set values also settable through module parameters
> under /sys/module, code inside #ifndef __KERNEL__ so include files can
> be shared with other PathScale code, code in ipath_i2c.c that might be
> simplified by using drivers/i2c, etc. I'd like to try to get a sense
> of whether I'm being too picky or whether PathScale really does need
> to fix these up before the driver is merged.

Yes, please fix this stuff before. The current driver looks like a horrible
mess.

Is there some political plot going where pathscale folks are forcing you to
send this out in this scheme? Otherwise I couldn't explain the code quality
magnitudes lower than normally expected from your merges.