Re: [openib-general] Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile

Robert Walsh
2005-12-20T00:33:01Z

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

> > @@ -0,0 +1,15 @@
> > +EXTRA_CFLAGS += -Idrivers/infiniband/include
> If this is needed then some header files should be moved to include/rdma

Actually, this is done by other IB drivers, too, so I assumed it was OK.
Roland, have you any comments on this?

> > +
> > +ipath_core-objs := ipath_copy.o ipath_driver.o \
> > + ipath_dwordcpy.o ipath_ht400.o ipath_i2c.o ipath_layer.o \
> > + ipath_lib.o ipath_mlock.o
> > +
> > +ib_ipath-objs := ipath_mad.o ipath_verbs.o
>
> Please use:
> ipath_core-y := ...
> ib_ipath-y := ...
>
> Use of -y let you do better Kconfig selection in the makefile, and is
> preferred compared to -objs

No problem.

Regards,
Robert.

--
Robert Walsh Email: rjwalsh@pathscale.com
PathScale, Inc. Phone: +1 650 934 8117
2071 Stierlin Court, Suite 200 Fax: +1 650 428 1969
Mountain View, CA 94043

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 481 bytes --]