Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

Thomas Gleixner
2005-12-15T17:04:25Z

On Thu, 2005-12-15 at 08:28 -0800, Linus Torvalds wrote:
> I would suggest that if you create a new "mutex" type, you just keep the
> lower-case name. Don't re-use the DECLARE_MUTEX format, just do
>
> struct mutex my_mutex = UNLOCKED_MUTEX;
>
> for new code that uses the new stuff.
>
> Think about it a bit. We don't have DECLARE_SPINLOCK either. Why?

Well, we have DEFINE_SPINLOCK() and we should have a matching one for
mutexes DEFINE_MUTEX().

The reason is that you can implement complex initialization for
debugging or extensions which can't be done by a var = INITIALZER,
because you dont have a reference to var.

tglx