Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

Jakub Jelinek
2005-12-13T10:12:06Z

On Tue, Dec 13, 2005 at 09:04:29AM +0000, Christoph Hellwig wrote:
> >
> > Remove -Wdeclaration-after-statement
> >
> > Now that gcc 2.95 is not supported anymore it's ok to use C99
> > style mixed declarations everywhere.
>
> Nack. This code style is pure obsfucation and we should disallow it forever.

Why? It greatly increases readability when variable declarations can be
moved close to their actual uses. glibc changed a lot of its codebase
this way and from my experience it really helps.

Jakub