From: David Brownell <david-b@pacbell.net>
To: Vitaly Wool <vwool@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 2.6-git 3/3] SPI core refresh: SPI/PNX bus driver and EEPROM driver
Date: Sun, 18 Dec 2005 12:02:48 -0800 [thread overview]
Message-ID: <200512181202.48218.david-b@pacbell.net> (raw)
In-Reply-To: <20051215130354.5ca3d99f.vwool@ru.mvista.com>
> --- /dev/null
> +++ linux-2.6.orig/drivers/spi/pnx4008-eeprom.c
> @@ -0,0 +1,121 @@
> ...
> +#define EEPROM_SIZE 256
> +#define DRIVER_NAME "EEPROM"
> +#define READ_BUFF_SIZE 160
Wouldn't it be better to have an EEPROM driver that's not hard-wired
to this particular devel board? And which could work on at least all
chips using eight bit addressing?
This seems to match the 25020 series SPI EEPROMS. (2 Kbits, 256 bytes.)
But the 25010 and 25040 also use 8 bit address protoocol ... and then
there are also chips using 16 bit addresses, and 24 bit ones.
Shouldn't board init code be able to just say "25640 at spi1 chipselect 3",
and have the driver know that means 8 KBytes with pagesize 32?
- Dave
next prev parent reply other threads:[~2005-12-18 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 9:58 [PATCH 2.6-git 0/3] SPI core refresh Vitaly Wool
2005-12-15 10:00 ` [PATCH 2.6-git 1/3] SPI core refresh: the core Vitaly Wool
2005-12-15 10:02 ` [PATCH 2.6-git 2/3] SPI core refresh: MTD dataflash driver Vitaly Wool
2005-12-15 10:03 ` [PATCH 2.6-git 3/3] SPI core refresh: SPI/PNX bus driver and EEPROM driver Vitaly Wool
2005-12-18 20:02 ` David Brownell [this message]
2005-12-19 7:57 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512181202.48218.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=vwool@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox