From: Al Viro <viro@ftp.linux.org.uk>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: linux-kernel@vger.kernel.org, js@linuxtv.org,
linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com
Subject: Re: [PATCH 1/5] - Fix 64-bit compile warnings
Date: Sun, 18 Dec 2005 15:56:22 +0000 [thread overview]
Message-ID: <20051218155622.GG27946@ftp.linux.org.uk> (raw)
In-Reply-To: <1134920704.6702.26.camel@localhost>
On Sun, Dec 18, 2005 at 01:23:45PM -0200, Mauro Carvalho Chehab wrote:
> Fix 64-bit compile warnings
> diff --git a/drivers/media/common/saa7146_hlp.c b/drivers/media/common/saa7146_hlp.c
> index ec52dff..be34ec4 100644
> --- a/drivers/media/common/saa7146_hlp.c
> +++ b/drivers/media/common/saa7146_hlp.c
> @@ -562,7 +562,7 @@ static void saa7146_set_position(struct
>
> int b_depth = vv->ov_fmt->depth;
> int b_bpl = vv->ov_fb.fmt.bytesperline;
> - u32 base = (u32)vv->ov_fb.base;
> + u32 base = (u32)(unsigned long)vv->ov_fb.base;
That's not "fix", that's "confuse gcc so it doesn't notice the problem
anymore"...
prev parent reply other threads:[~2005-12-18 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 15:23 [PATCH 1/5] - Fix 64-bit compile warnings Mauro Carvalho Chehab
2005-12-18 15:56 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051218155622.GG27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=js@linuxtv.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox