Re: [patch 10/15] Generic Mutex Subsystem, mutex-migration-helper-core.patch

Ingo Molnar
2005-12-19T16:41:53Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Mon, 2005-12-19 at 02:38 +0100, Ingo Molnar wrote:
> > Index: linux/include/linux/mutex.h
> > ===================================================================
> > --- linux.orig/include/linux/mutex.h
> > +++ linux/include/linux/mutex.h
>
> Maybe this should be in its own mutex-debug.h file with a:
>
> #ifndef __LIUNX_MUTEX_H
> # error Do not include this file directly, use mutex.h
> #endif

yeah.

> > +/*
> > + * Debugging variant of mutexes. The only difference is that they
> > accept
>
> Also, add a comment here that mutex_debug should NOT be used directly.
> This may seem obvious, but new Linux kernel programmers may just be
> scanning the code for what they would like to use and add it. At
> least let them know (although it may seem obvious) that this is just a
> temporary structure that will go away soon, and if they want to use
> mutexes, then use mutex, and don't be tempted to have a mutex up/down.

well, it could surface temporarily, as in 'could you try this
test-release, it also turns on mutexes, lets see whether it breaks' -
without the subsystem maintainer having to do a big patch changing all
the down()/up() calls to mutex_lock()/mutex_unlock() ...

Ingo