public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Sonny Rao <sonny@burdell.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-kernel@vger.kernel.org, clameter@sgi.com,
	sonnyrao@us.ibm.com
Subject: Re: cpu hotplug oops on 2.6.15-rc5
Date: Tue, 20 Dec 2005 10:40:57 +1100	[thread overview]
Message-ID: <20051219234056.GA11792@krispykreme> (raw)
In-Reply-To: <43A72350.40909@colorfullife.com>


Hi Manfred,

> Very odd call chain.
> Could you enable slab debugging?

Sonny and I had a look around, it seems to be in the
cpuup_callback() / CPU_DEAD case:

      if (!cpus_empty(mask)) {
              spin_unlock(&l3->list_lock);
              goto unlock_cache;
      }

      if (l3->shared) {
              free_block(cachep, l3->shared->entry,
                              l3->shared->avail, node);
              kfree(l3->shared);                <-------- HERE
              l3->shared = NULL;
      }

So we are removing the last cpu in a node, and tearing down the node
related structures. We looked at kfree() -> __cache_free() and we couldnt
convince ourselves that all the CONFIG_NUMA stuff in there wouldnt trip
over itself (since we would be doing the free on an alien node).

Anton

  parent reply	other threads:[~2005-12-19 23:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-19  5:16 cpu hotplug oops on 2.6.15-rc5 Sonny Rao
2005-12-19  6:41 ` Benjamin Herrenschmidt
2005-12-19  7:08   ` Sonny Rao
2005-12-19 21:17     ` Manfred Spraul
2005-12-19 23:16       ` SPAMHAUS-Re: " Sonny Rao
2005-12-19 23:40       ` Anton Blanchard [this message]
2005-12-22  9:27 ` Ravikiran G Thirumalai
     [not found]   ` <20051222173700.GA5723@localhost.localdomain>
2005-12-22 17:53     ` Sonny Rao
2005-12-22 18:37       ` Ravikiran G Thirumalai
2005-12-22 18:39         ` Sonny Rao
2005-12-22 18:54           ` Christoph Lameter
2005-12-22 19:09             ` Sonny Rao
2005-12-22 19:45         ` Sonny Rao
2005-12-28 19:30           ` Nathan Lynch
2005-12-29  0:30             ` Sonny Rao
2005-12-29  4:18               ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051219234056.GA11792@krispykreme \
    --to=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=sonny@burdell.org \
    --cc=sonnyrao@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox