public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: a.othieno@bluewin.ch (Arthur Othieno)
To: akpm@osdl.org
Cc: philb@gnu.org, linux-kernel@vger.kernel.org
Subject: [PATCH] v4l: don't ignore return from i2c_add_driver() for tuner-3036
Date: Mon, 19 Dec 2005 22:07:49 -0500	[thread overview]
Message-ID: <20051220030749.GA24700@krypton> (raw)

The call to i2c_add_driver() may actually fail, but tuner-3036 ignores
this and always returns 0, regardless.

Fix it up so it returns what i2c_add_driver() does, instead.

Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch>

---

 drivers/media/video/tuner-3036.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

b0a7aec914298ce1ceda98c730c950a08d8f0a99
diff --git a/drivers/media/video/tuner-3036.c b/drivers/media/video/tuner-3036.c
index 7920359..05e4ee2 100644
--- a/drivers/media/video/tuner-3036.c
+++ b/drivers/media/video/tuner-3036.c
@@ -193,8 +193,7 @@ static struct i2c_client client_template
 static int __init
 tuner3036_init(void)
 {
-	i2c_add_driver(&i2c_driver_tuner);
-	return 0;
+	return i2c_add_driver(&i2c_driver_tuner);
 }
 
 static void __exit
-- 
0.99.9n

                 reply	other threads:[~2005-12-20  3:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051220030749.GA24700@krypton \
    --to=a.othieno@bluewin.ch \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philb@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox