Re: [PATCH 10/15] misc: Make *[ug]id16 support optional

Geert Uytterhoeven
2005-11-11T10:23:20Z

On Fri, 11 Nov 2005, Matt Mackall wrote:
> Configurable 16-bit UID and friends support
>
> This allows turning off the legacy 16 bit UID interfaces on embedded platforms.
>
> text data bss dec hex filename
> 3330172 529036 190556 4049764 3dcb64 vmlinux-baseline
> 3328268 529040 190556 4047864 3dc3f8 vmlinux
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>
>
> Index: 2.6.14-misc/init/Kconfig
> ===================================================================
> --- 2.6.14-misc.orig/init/Kconfig 2005-11-09 11:21:02.000000000 -0800
> +++ 2.6.14-misc/init/Kconfig 2005-11-09 11:22:06.000000000 -0800
> @@ -364,7 +364,16 @@ config SYSENTER
> help
> Disabling this feature removes sysenter handling as well as
> vsyscall fixmaps.
> -
> +
> +config UID16
> + bool "Enable 16-bit UID system calls" if EMBEDDED
> + depends !ALPHA && !PPC && !PPC64 && !PARISC && !V850 && !ARCH_S390X

Wouldn't it be better to explicitly list the architectures that support it?
I assume new architectures won't implement it anyway?

> + depends !X86_64 || IA32_EMULATION
> + depends !SPARC64 || SPARC32_COMPAT

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds