Re: [PATCH rc6] block: Fix CDROMEJECT to work in more cases

[Jens Axboe <axboe@suse.de>]

On Tue, Dec 20 2005, Linus Torvalds wrote:
> 
> 
> On Tue, 20 Dec 2005, Jens Axboe wrote:
> > 
> > There _was_ a bug in the SCSI layer, because it had logic like this:
> > 
> >         if (rq_data_dir(req) == WRITE)
> >                 DMA_TO_DEVICE
> >         else if (req->data_len)
> >                 DMA_FROM_DEVICE
> >         else
> >                 DMA_NONE
> > 
> > which was buggy, because for it to transfer data to the device, both the
> > direction bit _and_ a data length must be set.
> 
> So this is fixed? Is that the iPod panic fix, or something else?

Yes it's fixed, James merged the fix(es) with you last week.

> If so, I'll drop that patch (although the "allow_removal" part of it 
> sounds sane to me still.. comments?)

I guess that's fine with me, the only thing I reject to is the 0x01 bit.

-- 
Jens Axboe