From: Jens Axboe <axboe@suse.de>
To: Ben Collins <ben.collins@ubuntu.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
Ben Collins <bcollins@ubuntu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH rc6] block: Fix CDROMEJECT to work in more cases
Date: Tue, 20 Dec 2005 21:53:07 +0100 [thread overview]
Message-ID: <20051220205306.GS3734@suse.de> (raw)
In-Reply-To: <1135111130.16754.23.camel@localhost.localdomain>
On Tue, Dec 20 2005, Ben Collins wrote:
> However, I don't see the issue with using READ. We know this isn't a
> write operation, we are sending a single command with no data. I know
> you say reads are precious, but 3 requests for something that isn't
> going to happen very often doesn't seem that bad.
It's not a READ either!
Yes I'm being stubborn, but my point stands. I'm not changing something
that is perfectly valid, "just because". If it finds a bug (you
mentioned ide-cd, I still want the details on that when you have the
time), then it's all for the better since it would bite us for other
paths as well.
In summary - it's not a bug, it doesn't need fixing.
> As for the 0x01, I don't know. The eject -s code does the exact same
> thing (AMR, SS:0x01, SS:0x02), so I copied the same mechanism because it
> is known to work.
Lets leave that out for now then, yes?
--
Jens Axboe
next prev parent reply other threads:[~2005-12-20 20:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-19 19:50 [PATCH rc6] block: Fix CDROMEJECT to work in more cases Ben Collins
2005-12-20 17:34 ` Linus Torvalds
2005-12-20 17:49 ` Jens Axboe
2005-12-20 18:08 ` Linus Torvalds
2005-12-20 18:38 ` Jens Axboe
2005-12-20 18:53 ` Linus Torvalds
2005-12-20 19:08 ` Jens Axboe
2005-12-20 20:38 ` Ben Collins
2005-12-20 20:53 ` Jens Axboe [this message]
2005-12-20 21:46 ` Ben Collins
2005-12-21 7:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051220205306.GS3734@suse.de \
--to=axboe@suse.de \
--cc=bcollins@ubuntu.com \
--cc=ben.collins@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox