From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: usb: replace __setup("nousb") with __module_param_call
Date: Thu, 22 Dec 2005 01:10:52 -0500 [thread overview]
Message-ID: <200512220110.52466.dtor_core@ameritech.net> (raw)
In-Reply-To: <20051220141504.31441a41.zaitcev@redhat.com>
On Tuesday 20 December 2005 17:15, Pete Zaitcev wrote:
> Fedora users complain that passing "nousbstorage" to the installer causes
> the rest of the USB support to disappear. The installer uses kernel command
> line as a way to pass options through Syslinux. The problem stems from the
> use of strncmp() in obsolete_checksetup().
>
I wonder if that strncmp() should be changed into something like
this (untested):
--- work.orig/init/main.c
+++ work/init/main.c
@@ -167,7 +167,7 @@ static int __init obsolete_checksetup(ch
p = __setup_start;
do {
int n = strlen(p->str);
- if (!strncmp(line, p->str, n)) {
+ if (!strncmp(line, p->str, n) && !isalnum(line[n])) {
if (p->early) {
/* Already done in parse_early_param? (Needs
* exact match on param part) */
--
Dmitry
next prev parent reply other threads:[~2005-12-22 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 22:15 usb: replace __setup("nousb") with __module_param_call Pete Zaitcev
2005-12-22 6:10 ` Dmitry Torokhov [this message]
2005-12-22 8:24 ` Pete Zaitcev
2006-01-03 6:47 ` Dmitry Torokhov
2006-01-03 7:07 ` Pete Zaitcev
2006-01-03 14:46 ` Dmitry Torokhov
2006-01-03 19:35 ` Pete Zaitcev
2006-01-03 20:34 ` [linux-usb-devel] " Alan Stern
2006-01-03 20:38 ` Dmitry Torokhov
2006-01-03 20:52 ` Alan Stern
2006-01-03 21:04 ` Dmitry Torokhov
2006-01-03 20:44 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512220110.52466.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox