From: Greg KH <greg@kroah.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>,
mbligh@google.com, linux-kernel@vger.kernel.org,
colpatch@us.ibm.com
Subject: Re: [PATCH] pci device ensure sysdata initialised
Date: Thu, 22 Dec 2005 15:51:01 -0800 [thread overview]
Message-ID: <20051222235101.GA2826@kroah.com> (raw)
In-Reply-To: <43AB3A1C.5070606@shadowen.org>
On Thu, Dec 22, 2005 at 11:43:24PM +0000, Andy Whitcroft wrote:
> Greg KH wrote:
>
> > Yeah, but this patch is just papering over that fact :(
> >
> > In fact, you will not put these devices on the proper node with this
> > patch, right? So I don't think it is what you want.
>
> If there is ACPI information for the machine I believe it will put them
> in the correct nodes; otherwise it behaves as we did in -mm1, in that
> they are not correctly located.
Well, why not properly locate them? That's my point :)
It seems you just put a default sysdata on a few places in the tree,
which fixed your boot problems. I'm thinking that isn't fixing the root
issue here of not probing the pci devices properly on these boxes. Does
that make more sense?
thanks,
greg k-h
next prev parent reply other threads:[~2005-12-22 23:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 7:40 2.6.15-rc5-mm3 Andrew Morton
2005-12-15 9:48 ` 2.6.15-rc5-mm3 Andi Kleen
2005-12-15 15:36 ` 2.6.15-rc5-mm3 Andi Kleen
2005-12-15 14:30 ` 2.6.15-rc5-mm3 Alexander E. Patrakov
2005-12-16 12:50 ` 2.6.15-rc5-mm3 Lenar Lõhmus
2005-12-16 23:17 ` 2.6.15-rc5-mm3 Greg KH
2005-12-17 0:15 ` 2.6.15-rc5-mm3 J.A. Magallon
2005-12-17 1:42 ` 2.6.15-rc5-mm3 Greg KH
2005-12-20 21:03 ` [PATCH] pci device sysdata may be null check in pcibus_to_node Andy Whitcroft
2005-12-20 23:16 ` Andrew Morton
2005-12-22 21:06 ` [PATCH] pci device ensure sysdata initialised Andy Whitcroft
2005-12-22 23:18 ` Greg KH
2005-12-22 23:43 ` Andy Whitcroft
2005-12-22 23:51 ` Greg KH [this message]
2005-12-22 23:56 ` Andy Whitcroft
2005-12-18 8:16 ` 2.6.15-rc5-mm3 Grant Coady
2005-12-18 11:31 ` 2.6.15-rc5-mm3 Rafael J. Wysocki
2005-12-18 19:54 ` 2.6.15-rc5-mm3 Grant Coady
2005-12-22 17:48 ` 2.6.15-rc5-mm3 Greg KH
2005-12-23 1:05 ` 2.6.15-rc5-mm3 David Brownell
2005-12-21 23:14 ` 2.6.15-rc5-mm3 Jesper Juhl
2005-12-22 4:16 ` 2.6.15-rc5-mm3 Con Kolivas
2005-12-22 18:13 ` 2.6.15-rc5-mm3 Mattia Dongili
2005-12-29 23:46 ` 2.6.15-rc5-mm3 [BUG] smp_processor_id() in preemptible code Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051222235101.GA2826@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox