From: Adrian Bunk <bunk@stusta.de>
To: Marc Koschewski <marc@osknowledge.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] conditionally #ifdef-out unused DiB3000M-C/P functions
Date: Fri, 23 Dec 2005 03:04:43 +0100 [thread overview]
Message-ID: <20051223020443.GE27525@stusta.de> (raw)
In-Reply-To: <20051221113742.GA5611@stiffy.osknowledge.org>
On Wed, Dec 21, 2005 at 12:37:43PM +0100, Marc Koschewski wrote:
> The following tiny patch removes the two DiB3000M-C/P functions
>
> int dibusb_dib3000mc_tuner_attach()
> int dibusb_dib3000mc_frontend_attach()
>
> that are not needed in case the module is not compiled. The modules a800 as well
> as nova-t-usb2 select DVB_DIB3000MB in Kconfig thus the functions will be
> enabled due to the module being compiled.
In theory, you could add #ifdef's in thousands of places of the kernel
around functions similarly small to these two ones or sometimes bigger
functions.
In practice, this would cause breakages in many configurations because
the #ifdef's might either be wrong (as in your patch) or become wrong
over time.
> Regards,
> Marc
> *** dibusb-common.c-orig 2005-12-21 11:04:49.000000000 +0100
> --- dibusb-common.c 2005-12-21 11:05:32.000000000 +0100
> *************** int dibusb_read_eeprom_byte(struct dvb_u
> *** 168,173 ****
> --- 168,174 ----
> }
> EXPORT_SYMBOL(dibusb_read_eeprom_byte);
>
> + #ifdef CONFIG_DVB_USB_DIBUSB_MC
>...
This breaks with DVB_USB_DIBUSB_MC=m.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2005-12-23 2:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 11:37 [PATCH] conditionally #ifdef-out unused DiB3000M-C/P functions Marc Koschewski
2005-12-21 13:52 ` [PATCH 2/2] conditionally #ifdef-out unused DiB3000M-C/P defs Marc Koschewski
2005-12-23 2:05 ` Adrian Bunk
2005-12-23 2:04 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051223020443.GE27525@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@osknowledge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox