From: Dave Jones <davej@redhat.com>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC] [PATCH] Add memcpy32 function
Date: Thu, 22 Dec 2005 21:49:43 -0500 [thread overview]
Message-ID: <20051223024943.GC27537@redhat.com> (raw)
In-Reply-To: <1135301759.4212.76.camel@serpentine.pathscale.com>
On Thu, Dec 22, 2005 at 05:35:59PM -0800, Bryan O'Sullivan wrote:
> In response to the comments that followed Roland Dreier posting our
> InfiniPath driver for review last week, we've been making some cleanups
> to our driver code.
>
> As our chip requires 32-bit accesses, we need a copy function that
> guarantees operating in such terms. It was suggested that we make this
> generic, with arch-specific optimised versions.
>
> This patch introduces the generic copy routine, memcpy32. At Andrew's
> suggestion, I've put it in a new header file, include/linux/io.h, which
> I've styled after include/linux/string.h.
io.h is a very generic sounding name for something that just houses
a memcpy variant. What's wrong with calling a spade a spade,
and using memcpy32.h ?
Dave
next prev parent reply other threads:[~2005-12-23 2:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 1:35 [RFC] [PATCH] Add memcpy32 function Bryan O'Sullivan
2005-12-23 2:49 ` Dave Jones [this message]
2005-12-23 17:16 ` Matt Mackall
2005-12-23 17:42 ` Christoph Hellwig
2005-12-23 18:14 ` Matt Mackall
2005-12-23 23:50 ` Bryan O'Sullivan
2005-12-28 11:01 ` Andi Kleen
2005-12-28 15:00 ` Bryan O'Sullivan
2005-12-28 17:50 ` Andreas Kleen
2005-12-28 18:11 ` Bryan O'Sullivan
2005-12-28 18:22 ` Andreas Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051223024943.GC27537@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox