From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: [PATCH] nfsd4_lock() returns bogus values to clients
Date: Sun, 25 Dec 2005 07:30:32 +0000 [thread overview]
Message-ID: <20051225073032.GA27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20051225064933.GZ27946@ftp.linux.org.uk>
On Sun, Dec 25, 2005 at 06:49:33AM +0000, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> Date: 1135493243 -0500
>
> missing nfserror() in default case of a switch by return value of
> posix_lock_file(); as the result we send negative host-endian to
> clients that expect positive network-endian, preferably mentioned
> in RFC... BTW, that case is not impossible - posix_lock_file()
> can return -ENOLCK and we do not handle that one explicitly.
Gaack... s/nfserror/nfserrno/, of course...
prev parent reply other threads:[~2005-12-25 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 6:29 [PATCH] nfsd/vfs.c: endianness fixes Al Viro
2005-12-25 6:44 ` [PATCH] nfsd4_truncate() bogus return value Al Viro
2005-12-25 6:48 ` [PATCH] NFSERR_SERVERFAULT returned host-endian Al Viro
2005-12-25 6:49 ` [PATCH] nfsd4_lock() returns bogus values to clients Al Viro
2005-12-25 7:30 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051225073032.GA27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox