From: Kees Cook <kees@outflux.net>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: zlib_inflate "r.base" uninitialized compile warnings
Date: Sun, 25 Dec 2005 12:39:30 -0800 [thread overview]
Message-ID: <20051225203929.GP18040@outflux.net> (raw)
In-Reply-To: <20051225183406.GB27946@ftp.linux.org.uk>
On Sun, Dec 25, 2005 at 06:34:06PM +0000, Al Viro wrote:
> NAK. That sort of patches is only going to hide real problems in the
> code where such warnings are _not_ false positives.
>
> Let me put it that way: what bug are you fixing in that patch? Is
> there a codepath that would lead to use of r without initialization?
> If there is - show it; if there is not - why are you patching kernel
> and not gcc?
Well, good point. My only question would be: why are other
"uninitialized" variables masked in the same way in that code?
Also, perhaps the phrasing in SubmittingPatches should be changed.
Currently (for "trivial" patches) it says:
Warning fixes (cluttering with useless warnings is bad)
Is that warning considered "useful"? Should this hint, instead, read:
Warning fixes (make sure the warning is "real", if not, patch gcc)
:)
--
Kees Cook @outflux.net
next prev parent reply other threads:[~2005-12-25 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 18:07 [PATCH] lib: zlib_inflate "r.base" uninitialized compile warnings Kees Cook
2005-12-25 18:34 ` Al Viro
2005-12-25 20:39 ` Kees Cook [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-25 20:08 James Lamanna
2005-12-25 20:35 ` Kees Cook
2005-12-25 20:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051225203929.GP18040@outflux.net \
--to=kees@outflux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox