[PATCH] Remove unneeded packed attribute

[PATCH] Remove unneeded packed attribute

[Brian Gerst]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

GCC 4.1 gives the following warning:
include/asm/mpspec.h:79: warning: ‘packed’ attribute ignored for field 
of type ‘unsigned char[5u]’

The packed attribute isn't really necessary anyways so just remove it.

Signed-off-by: Brian Gerst <bgerst@didntduck.org>

[-- Attachment #2: mpspec-packed --]
[-- Type: text/plain, Size: 1571 bytes --]

[PATCH] Remove unneeded packed attribute

GCC 4.1 gives the following warning:
include/asm/mpspec.h:79: warning: ‘packed’ attribute ignored for field of type ‘unsigned char[5u]’

The packed attribute isn't really necessary anyways so just remove it.

Signed-off-by: Brian Gerst <bgerst@didntduck.org>

---
commit 58c5813206aec0df47a061ad31c457cd6e176d12
tree 2b900ac50c67c30f87115b1a9f752f9f2e871556
parent 9a4863865f6c539b799adf0f41de862a7163d819
author Brian Gerst <bgerst@didntduck.org> Tue, 27 Dec 2005 18:48:21 -0500
committer Brian Gerst <bgerst@didntduck.org> Tue, 27 Dec 2005 18:48:21 -0500

 include/asm-i386/mpspec_def.h |    2 +-
 include/asm-x86_64/mpspec.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-i386/mpspec_def.h b/include/asm-i386/mpspec_def.h
index a961093..76feedf 100644
--- a/include/asm-i386/mpspec_def.h
+++ b/include/asm-i386/mpspec_def.h
@@ -75,7 +75,7 @@ struct mpc_config_bus
 {
 	unsigned char mpc_type;
 	unsigned char mpc_busid;
-	unsigned char mpc_bustype[6] __attribute((packed));
+	unsigned char mpc_bustype[6];
 };
 
 /* List of Bus Type string values, Intel MP Spec. */
diff --git a/include/asm-x86_64/mpspec.h b/include/asm-x86_64/mpspec.h
index 6f8a17d..10248a9 100644
--- a/include/asm-x86_64/mpspec.h
+++ b/include/asm-x86_64/mpspec.h
@@ -76,7 +76,7 @@ struct mpc_config_bus
 {
 	unsigned char mpc_type;
 	unsigned char mpc_busid;
-	unsigned char mpc_bustype[6] __attribute((packed));
+	unsigned char mpc_bustype[6];
 };
 
 /* List of Bus Type string values, Intel MP Spec. */

Re: [PATCH] Remove unneeded packed attribute

[Dave Jones]

On Tue, Dec 27, 2005 at 07:01:36PM -0500, Brian Gerst wrote:
 > GCC 4.1 gives the following warning:
 > include/asm/mpspec.h:79: warning: ‘packed’ attribute ignored for field 
 > of type ‘unsigned char[5u]’
 > 
 > The packed attribute isn't really necessary anyways so just remove it.
 > 
 > Signed-off-by: Brian Gerst <bgerst@didntduck.org>

We've been carrying exactly the same diff in the Fedora rawhide kernel for
the last week or two.

ACKed by: Dave Jones <davej@redhat.com>

		Dave