From: Nathan Lynch <ntl@pobox.com>
To: Sonny Rao <sonny@burdell.org>
Cc: Ravikiran G Thirumalai <kiran@scalex86.org>,
linux-kernel@vger.kernel.org, manfred@colorfullife.com,
clameter@sgi.com, anton@samba.org, shai@scalex86.org,
sonnyrao@us.ibm.com, alokk@calsoftinc.com
Subject: Re: cpu hotplug oops on 2.6.15-rc5
Date: Wed, 28 Dec 2005 13:30:12 -0600 [thread overview]
Message-ID: <20051228193012.GF12674@localhost.localdomain> (raw)
In-Reply-To: <20051222194511.GB24385@kevlar.burdell.org>
I wonder if this is related to the problem Sonny is seeing -- powerpc's
definitions of cpu_to_node et al. are not being used. The culprit is
some too-clever preprocessor usage in asm-generic/topology.h, for
example:
#ifndef cpu_to_node
#define cpu_to_node(cpu) (0)
#endif
But asm-powerpc/topology.h has cpu_to_node defined as a static inline
(which does not make it a preprocessor symbol), so we get the generic
- and incorrect - definition.
Does removing the #include of asm-generic/topology.h from the bottom
of asm-powerpc/topology.h have any effect?
next prev parent reply other threads:[~2005-12-28 19:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-19 5:16 cpu hotplug oops on 2.6.15-rc5 Sonny Rao
2005-12-19 6:41 ` Benjamin Herrenschmidt
2005-12-19 7:08 ` Sonny Rao
2005-12-19 21:17 ` Manfred Spraul
2005-12-19 23:16 ` SPAMHAUS-Re: " Sonny Rao
2005-12-19 23:40 ` Anton Blanchard
2005-12-22 9:27 ` Ravikiran G Thirumalai
[not found] ` <20051222173700.GA5723@localhost.localdomain>
2005-12-22 17:53 ` Sonny Rao
2005-12-22 18:37 ` Ravikiran G Thirumalai
2005-12-22 18:39 ` Sonny Rao
2005-12-22 18:54 ` Christoph Lameter
2005-12-22 19:09 ` Sonny Rao
2005-12-22 19:45 ` Sonny Rao
2005-12-28 19:30 ` Nathan Lynch [this message]
2005-12-29 0:30 ` Sonny Rao
2005-12-29 4:18 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051228193012.GF12674@localhost.localdomain \
--to=ntl@pobox.com \
--cc=alokk@calsoftinc.com \
--cc=anton@samba.org \
--cc=clameter@sgi.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=shai@scalex86.org \
--cc=sonny@burdell.org \
--cc=sonnyrao@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox