From: Roland Dreier <roland@topspin.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [PATCH][5/11] IB/mthca: fix reset value endianness
Date: Wed, 2 Mar 2005 21:31:22 -0800 [thread overview]
Message-ID: <2005322131.ube7cIPz9y7840bB@topspin.com> (raw)
In-Reply-To: <2005322131.oecVhU1CS3swCooO@topspin.com>
MTHCA_RESET_VALUE must always be swapped, since the HCA expects to see
it in big-endian order and we write it with writel. This means on
little-endian systems we have to swap it to big-endian order before
writing, and on big-endian systems we need to swap it to make up for
the additional swap that writel will do. This fixes resetting the HCA
on big-endian machines.
Signed-off-by: Roland Dreier <roland@topspin.com>
--- linux-export.orig/drivers/infiniband/hw/mthca/mthca_reset.c 2005-03-02 20:26:02.970843287 -0800
+++ linux-export/drivers/infiniband/hw/mthca/mthca_reset.c 2005-03-02 20:26:12.219835642 -0800
@@ -50,7 +50,7 @@
struct pci_dev *bridge = NULL;
#define MTHCA_RESET_OFFSET 0xf0010
-#define MTHCA_RESET_VALUE cpu_to_be32(1)
+#define MTHCA_RESET_VALUE swab32(1)
/*
* Reset the chip. This is somewhat ugly because we have to
next prev parent reply other threads:[~2005-03-03 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 5:31 [PATCH][0/11] InfiniBand fixes Roland Dreier
2005-03-03 5:31 ` [PATCH][1/11] IB: simplify MAD code Roland Dreier
2005-03-03 5:31 ` [PATCH][2/11] IB: fix vendor MAD deregistration Roland Dreier
2005-03-03 5:31 ` [PATCH][3/11] IB: sparse fixes Roland Dreier
2005-03-03 5:31 ` [PATCH][4/11] IB/mthca: add missing break Roland Dreier
2005-03-03 5:31 ` Roland Dreier [this message]
2005-03-03 5:31 ` [PATCH][6/11] IB/ipoib: fix rx memory leak Roland Dreier
2005-03-03 5:31 ` [PATCH][7/11] IB/ipoib: use list_for_each_entry_safe when required Roland Dreier
2005-03-03 5:31 ` [PATCH][8/11] IB/ipoib: rename global symbols Roland Dreier
2005-03-03 5:31 ` [PATCH][9/11] IB/ipoib: small fixes Roland Dreier
2005-03-03 5:31 ` [PATCH][10/11] IB/ipoib: don't call ipoib_put_ah with lock held Roland Dreier
2005-03-03 5:31 ` [PATCH][11/11] IB/ipoib: fix locking on path deletion Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2005322131.ube7cIPz9y7840bB@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox