From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <ak@suse.de>
Cc: lkml <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Nicolas Pitre <nico@cam.org>,
Jes Sorensen <jes@trained-monkey.org>,
Al Viro <viro@ftp.linux.org.uk>, Oleg Nesterov <oleg@tv-sign.ru>,
David Howells <dhowells@redhat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [patch 05/19] mutex subsystem, add include/asm-x86_64/mutex.h
Date: Mon, 2 Jan 2006 18:03:26 +0100 [thread overview]
Message-ID: <20060102170326.GA5593@elte.hu> (raw)
In-Reply-To: <20060102164605.GB7222@wotan.suse.de>
* Andi Kleen <ak@suse.de> wrote:
> > + : "rax", "rsi", "rdx", "rcx", \
> > + "r8", "r9", "r10", "r11", "memory"); \
>
> I think it would be still better if you used the stubs in
> arch/x86_64/lib/thunk.S and not clobber all the registers. While it
> won't make that much difference for the out of line mutexes it will
> generate better code for inline mutexes, and if someone ever decides
> they're a good idea the code will be ready.
i didnt want to add it to thunk.S because right now it would cause an
unnecessary slowdown for the slowpath, by quite a number of
instructions: due to the indiscriminate register-saving/restoring done
in thunk.S.
even though it's a "slow path" relative to the fastpath, we shouldnt
slow it down unnecessarily. So if someone wants to play with more
inlining later on, this has to be done in context of that effort.
Ingo
next prev parent reply other threads:[~2006-01-02 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-02 16:33 [patch 05/19] mutex subsystem, add include/asm-x86_64/mutex.h Ingo Molnar
2006-01-02 16:46 ` Andi Kleen
2006-01-02 17:03 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-03 10:07 Ingo Molnar
2006-01-03 16:46 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060102170326.GA5593@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
--cc=oleg@tv-sign.ru \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox