From: Denis Vlasenko <vda@ilport.com.ua>
To: rmk+serial@arm.linux.org.uk
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fix warning in 8250.c
Date: Tue, 3 Jan 2006 10:12:48 +0200 [thread overview]
Message-ID: <200601031012.49068.vda@ilport.com.ua> (raw)
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
CC drivers/serial/8250.o
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: 'transmit_chars' declared inline after being called
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: previous declaration of 'transmit_chars' was here
Since this function is not small, inlining effect is way below noise floor.
Let's just remove _INLINE_.
--
vda
[-- Attachment #2: linux-2.6.15-rc7.inline.patch --]
[-- Type: text/x-diff, Size: 809 bytes --]
CC drivers/serial/8250.o
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: 'transmit_chars' declared inline after being called
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: previous declaration of 'transmit_chars' was here
diff -urpN linux-2.6.15-rc7.src/drivers/serial/8250.c linux-2.6.15-rc7.fix/drivers/serial/8250.c
--- linux-2.6.15-rc7.src/drivers/serial/8250.c Fri Dec 30 14:18:03 2005
+++ linux-2.6.15-rc7.fix/drivers/serial/8250.c Sun Jan 1 16:56:17 2006
@@ -1217,7 +1217,7 @@ receive_chars(struct uart_8250_port *up,
*status = lsr;
}
-static _INLINE_ void transmit_chars(struct uart_8250_port *up)
+static void transmit_chars(struct uart_8250_port *up)
{
struct circ_buf *xmit = &up->port.info->xmit;
int count;
next reply other threads:[~2006-01-03 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 8:12 Denis Vlasenko [this message]
2006-01-04 18:14 ` [PATCH] fix warning in 8250.c Russell King
2006-01-04 18:18 ` Christoph Hellwig
2006-01-04 19:12 ` Russell King
2006-01-04 23:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601031012.49068.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox