From: Al Viro <viro@ftp.linux.org.uk>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCHSET] thread_info annotations and fixes
Date: Tue, 3 Jan 2006 22:53:50 +0000 [thread overview]
Message-ID: <20060103225350.GM27946@ftp.linux.org.uk> (raw)
In-Reply-To: <1136328105.3658.2.camel@mulgrave>
On Tue, Jan 03, 2006 at 05:41:45PM -0500, James Bottomley wrote:
> As long as this is just wrappering the existing pointers, then that's
> fine, but just in case it matters, I should point out that, at least for
> parisc, the wrappering is incomplete: we have references to the
> thread_info pointer in the task struct via our assembly glue as well (in
> just two places: the smp secondary CPU start and the _switch_to
> implementation).
You and a _lot_ of other architectures. That's fine - nobody suggests
centrally forced changes of data structure layouts, etc. These decisions
belong to architecture and assembler code is obviously supposed to be
aware of WTF it is doing; such annotations belong on C side of things.
prev parent reply other threads:[~2006-01-03 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 21:07 [PATCHSET] thread_info annotations and fixes Al Viro
2006-01-03 21:15 ` Al Viro
2006-01-03 22:41 ` James Bottomley
2006-01-03 22:53 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060103225350.GM27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox