public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86_64: fix IRQ vector reservations
@ 2006-01-03 23:35 Jason Uhlenkott
  2006-01-03 23:49 ` Andi Kleen
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Uhlenkott @ 2006-01-03 23:35 UTC (permalink / raw)
  To: ak; +Cc: linux-kernel

It looks like the new scalable TLB flush code for x86_64 is claiming
one more IRQ vector than it actually uses.

Signed-off-by: Jason Uhlenkott <jasonuhl@sgi.com>


Index: linux/include/asm-x86_64/hw_irq.h
===================================================================
--- linux.orig/include/asm-x86_64/hw_irq.h	2006-01-02 19:21:10.000000000 -0800
+++ linux/include/asm-x86_64/hw_irq.h	2006-01-03 15:18:36.923399691 -0800
@@ -46,8 +46,6 @@
  *  some of the following vectors are 'rare', they are merged
  *  into a single vector (CALL_FUNCTION_VECTOR) to save vector space.
  *  TLB, reschedule and local APIC vectors are performance-critical.
- *
- *  Vectors 0xf0-0xf9 are free (reserved for future Linux use).
  */
 #define SPURIOUS_APIC_VECTOR	0xff
 #define ERROR_APIC_VECTOR	0xfe
@@ -56,8 +54,8 @@
 #define KDB_VECTOR		0xfb	/* reserved for KDB */
 #define THERMAL_APIC_VECTOR	0xfa
 #define THRESHOLD_APIC_VECTOR   0xf9
-#define INVALIDATE_TLB_VECTOR_END	0xf8
-#define INVALIDATE_TLB_VECTOR_START	0xf0	/* f0-f8 used for TLB flush */
+#define INVALIDATE_TLB_VECTOR_END	0xf7
+#define INVALIDATE_TLB_VECTOR_START	0xf0	/* f0-f7 used for TLB flush */
 
 #define NUM_INVALIDATE_TLB_VECTORS	8
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86_64: fix IRQ vector reservations
  2006-01-03 23:35 [PATCH] x86_64: fix IRQ vector reservations Jason Uhlenkott
@ 2006-01-03 23:49 ` Andi Kleen
  0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-01-03 23:49 UTC (permalink / raw)
  To: Jason Uhlenkott; +Cc: linux-kernel

On Wednesday 04 January 2006 00:35, Jason Uhlenkott wrote:
> It looks like the new scalable TLB flush code for x86_64 is claiming
> one more IRQ vector than it actually uses.

Thanks for noticing - you seem to have sharper eyes than me.

Should probably free the KDB vector too since it's totally useless
(it's an NMI and NMIs always get delivered to vector NMI_VECTOR)

-Andi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-03 23:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-03 23:35 [PATCH] x86_64: fix IRQ vector reservations Jason Uhlenkott
2006-01-03 23:49 ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox