Re: Digital Audio Extraction with ATAPI drives far from perfect

Jens Axboe
2006-01-09T10:01:26Z

On Mon, Jan 09 2006, Sebastian wrote:
> On Mo, Jan 09, 2006 at 10:30:25 +0100, Jens Axboe wrote:
> > Sebastian, care to try one more thing? Patch your kernel with this
> > little patch and try ripping a known "faulty" track again _not_ using
> > SG_IO. See if that produces the same faulty results again, or if it
> > actually works.
> >
> > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> > index 1539603..2e44d81 100644
> > --- a/drivers/cdrom/cdrom.c
> > +++ b/drivers/cdrom/cdrom.c
> > @@ -426,7 +426,7 @@ int register_cdrom(struct cdrom_device_i
> > cdi->exit = cdrom_mrw_exit;
> >
> > if (cdi->disk)
> > - cdi->cdda_method = CDDA_BPC_FULL;
> > + cdi->cdda_method = CDDA_BPC_SINGLE;
> > else
> > cdi->cdda_method = CDDA_OLD;
> >
> >
> > --
> > Jens Axboe
> >
> Hi Jens,
>
> I applied your patch, recompiled the kernel, rebooted and recompiled
> cdparanoia without the Red Hat patches. Extracting the first track of my
> test cd the result was the same as without the kernel patch with ide-cd
> using the cooked interface (md5 e8319ccc20d053557578b9ca3eb368dd).
>
> Sorry :)

Well it's actually a good thing, because then at least it's not a bug
with the multi-frame extraction. So my guess would still be at the error
correction possibilities that the application has, in which case
CDROMREADAUDIO is just an inferior interface for this sort of thing. It
also doesn't give the issuer a chance to look at potential error
reasons, since the extended status isn't available.

--
Jens Axboe