public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: Re: [patch 2.6.15] i386: Optimize local APIC timer interrupt code
Date: Wed, 4 Jan 2006 15:01:39 -0800	[thread overview]
Message-ID: <20060104150139.34829833.akpm@osdl.org> (raw)
In-Reply-To: <200601041352_MC3-1-B550-4606@compuserve.com>

Chuck Ebbert <76306.1226@compuserve.com> wrote:
>
> Local APIC timer interrupt happens HZ times per second on each CPU.
> 
> Optimize it for the case where profile multiplier equals one and does
> not change (99+% of cases); this saves about 20 CPU cycles on Pentium II.
> 
> Also update the old multiplier immediately after noticing it changed,
> while values are register-hot, saving eight bytes of stack depth.

The code which you're patching is cheerfully nuked by a patch in Andi's
tree:
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/no-subjiffy-profile

I don't immediately understand that patch and I don't recall seeing it
discussed - maybe I was asleep.

It removes the profile multiplier (readprofile -M).  I've used that
occasionally, but can't say that I noticed much benefit from it.

What's the thinking here?

  reply	other threads:[~2006-01-04 23:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-04 18:48 [patch 2.6.15] i386: Optimize local APIC timer interrupt code Chuck Ebbert
2006-01-04 23:01 ` Andrew Morton [this message]
2006-01-05  6:03 ` Willy Tarreau
  -- strict thread matches above, loose matches on Subject: below --
2006-01-05  0:17 Chuck Ebbert
2006-01-05  6:38 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060104150139.34829833.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=76306.1226@compuserve.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox