From: Andrew Morton <akpm@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: hch@infradead.org, vda@ilport.com.ua,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] fix warning in 8250.c
Date: Wed, 4 Jan 2006 15:51:22 -0800 [thread overview]
Message-ID: <20060104155122.0bdfcffb.akpm@osdl.org> (raw)
In-Reply-To: <20060104191241.GF3119@flint.arm.linux.org.uk>
Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>
> > While we're at it can we please kill _INLINE_? Those functions that should
> > be inlined can become inline, but this macro just obsfucates the serial code.
>
> No idea - I don't know about x86 nuances and why they wanted:
>
> #if defined(__i386__) && (defined(CONFIG_M386) || defined(CONFIG_M486))
> #define _INLINE_ inline
> #else
> #define _INLINE_
> #endif
>
> Maybe someone in the x86 world needs to comment? Does the above even
> mean that we'll ever inline anything marked _INLINE_ ?
I suspect the reasoning behind this is lost in the mists of pre-bk time.
I'd be inclined to just nuke it and see what happens. Nothing, I expect.
prev parent reply other threads:[~2006-01-04 23:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 8:12 [PATCH] fix warning in 8250.c Denis Vlasenko
2006-01-04 18:14 ` Russell King
2006-01-04 18:18 ` Christoph Hellwig
2006-01-04 19:12 ` Russell King
2006-01-04 23:51 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060104155122.0bdfcffb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tytso@mit.edu \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox