From: Andi Kleen <ak@suse.de>
To: "Protasevich, Natalie" <Natalie.Protasevich@unisys.com>
Cc: "Peter Hagervall" <hager@cs.umu.se>,
"Andrew Morton" <akpm@osdl.org>,
"Eric Sesterhenn / snakebyte" <snakebyte@gmx.de>,
linux-kernel@vger.kernel.org
Subject: Re: [Patch] es7000 broken without acpi
Date: Wed, 4 Jan 2006 16:40:30 +0100 [thread overview]
Message-ID: <200601041640.30909.ak@suse.de> (raw)
In-Reply-To: <19D0D50E9B1D0A40A9F0323DBFA04ACC023B09B4@USRV-EXCH4.na.uis.unisys.com>
On Wednesday 04 January 2006 16:05, Protasevich, Natalie wrote:
> The only possible problem I see with that patch is making genapic
> dependant on ACPI, which I'm not sure about (for example, if Summit
> would want that, but nobody commented back then...Andi, what do you
> think?) As for ES7000, it fixes build problem overall, however, maybe it
> would be prudent to make it builldable even without its dependency on
> ACPI, just for correctness sake, meaning properly #ifdef-ing ACPI parts,
> this will make it more versatile (even though I cannot think of
> situation it might be used...Andi, what do you think? :)
I haven't looked at it in detail, but likely it's better to
add the necessary ifdefs to es7000 to compile without ACPI
than making genapic dependent on ACPI. Not that it makes
that much difference in practice, but it would be cleaner this
way.
-Andi
next prev parent reply other threads:[~2006-01-04 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 15:05 [Patch] es7000 broken without acpi Protasevich, Natalie
2006-01-04 15:40 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-04 2:46 Protasevich, Natalie
2006-01-04 1:36 Protasevich, Natalie
2006-01-04 1:51 ` Andrew Morton
2005-12-12 22:50 Eric Sesterhenn / snakebyte
2006-01-03 23:48 ` Andrew Morton
2006-01-04 10:05 ` Peter Hagervall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601041640.30909.ak@suse.de \
--to=ak@suse.de \
--cc=Natalie.Protasevich@unisys.com \
--cc=akpm@osdl.org \
--cc=hager@cs.umu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox