From: Chuck Ebbert <76306.1226@compuserve.com>
To: Willy Tarreau <willy@w.ods.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.15] i386: Optimize local APIC timer interrupt code
Date: Thu, 5 Jan 2006 01:38:32 -0500 [thread overview]
Message-ID: <200601050141_MC3-1-B553-82B6@compuserve.com> (raw)
In-Reply-To: <20060105060314.GB7142@w.ods.org>
On Thu, 5 Jan 2006 at 07:03:14 +0100, Willy Tarreau wrote:
> + if (likely(--per_cpu(prof_counter, cpu)) <= 0) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
are you sure about this ? it looks suspicious to me. I would have
expected something like this instead :
+ if (likely(--per_cpu(prof_counter, cpu) <= 0)) {
Nice catch, proving yet again the value of posting code for review!
--
Chuck
Currently reading: _Thud!_ by Terry Pratchett
next reply other threads:[~2006-01-05 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 6:38 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-05 0:17 [patch 2.6.15] i386: Optimize local APIC timer interrupt code Chuck Ebbert
2006-01-04 18:48 Chuck Ebbert
2006-01-04 23:01 ` Andrew Morton
2006-01-05 6:03 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601050141_MC3-1-B553-82B6@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox