Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers

Jörn Engel
2006-01-02T20:19:09Z

On Mon, 2 January 2006 21:05:31 +0100, Krzysztof Halasa wrote:
> Arjan van de Ven <arjan@infradead.org> writes:
>
> > it's by far not only gains. And maintenance costs too.
>
> Anyway, distinctive "inlines" could help here, right?

Not really. Your example, as Linus already explained, is a great
example of how _not_ to inline stuff. If in doubt, don't inline. If
a function is called just once, don't inline unless there are other
good reasons for it. If you get a minimal gain (10 bytes) in text
size, don't inline. The maintenance issue is more important.

Jörn

--
A defeated army first battles and then seeks victory.
-- Sun Tzu