From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Deepak Saxena <dsaxena@plexity.net>,
Jeff Garzik <jgarzik@pobox.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix EISA/VLB/PCI network controllers alignment in menuconfig
Date: Thu, 5 Jan 2006 20:51:53 +0000 [thread overview]
Message-ID: <20060105205153.GB15968@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20051227210628.0575f672.khali@linux-fr.org>
On Tue, Dec 27, 2005 at 09:06:28PM +0100, Jean Delvare wrote:
> The CS89x0 Kconfig entry currently breaks the alignment of all
> "EISA, VLB, PCI and on board controllers" that follow it in menuconfig.
> This patch fixes it.
>
> This bug was introduced in version 2.6.13-rc1. A first, different fix
> attempt was made by Deepak Saxena:
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=712cb1ebb1653538527500165d8382ca48a7fca1
>
> But it seems it was then overwritten by a subsequent (unsigned?) changeset
> from Russell King:
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e399822da0f99f8486c33c47e7ae0d32151461e5
It shouldn't have been overwritten - it's probably the result of a
mis-merge. I would appear that Deepak's change went in via one tree
and mine via my own tree.
As far as that change being unsigned, I don't see why the removal of
a previous addition would require a Sign-off. We never signed-off
for undoing BK changesets so I'm merely following the established
modus operandi.
I have no view on your patch since I never use any of the config
tools apart from oldconfig.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-01-05 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-27 20:06 [PATCH] Fix EISA/VLB/PCI network controllers alignment in menuconfig Jean Delvare
2006-01-05 20:51 ` Russell King [this message]
2006-01-06 7:53 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060105205153.GB15968@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dsaxena@plexity.net \
--cc=jgarzik@pobox.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox