* [2.6 patch] scsi_transport_spi.c: make print_nego() static
@ 2006-01-05 22:39 Adrian Bunk
2006-01-05 22:44 ` Matthew Wilcox
2006-01-07 1:26 ` Diego Calleja
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Bunk @ 2006-01-05 22:39 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: James Bottomley, linux-scsi, linux-kernel
This patch makes a needlessly global function static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm1-full/drivers/scsi/scsi_transport_spi.c.old 2006-01-05 22:52:19.000000000 +0100
+++ linux-2.6.15-mm1-full/drivers/scsi/scsi_transport_spi.c 2006-01-05 22:52:28.000000000 +0100
@@ -1075,7 +1075,7 @@
/* 0x04 */ "Parallel Protocol Request"
};
-void print_nego(const unsigned char *msg, int per, int off, int width)
+static void print_nego(const unsigned char *msg, int per, int off, int width)
{
if (per) {
char buf[20];
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] scsi_transport_spi.c: make print_nego() static
2006-01-05 22:39 [2.6 patch] scsi_transport_spi.c: make print_nego() static Adrian Bunk
@ 2006-01-05 22:44 ` Matthew Wilcox
2006-01-07 1:26 ` Diego Calleja
1 sibling, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2006-01-05 22:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James Bottomley, linux-scsi, linux-kernel
On Thu, Jan 05, 2006 at 11:39:18PM +0100, Adrian Bunk wrote:
> This patch makes a needlessly global function static.
Sure, makes sense. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] scsi_transport_spi.c: make print_nego() static
2006-01-05 22:39 [2.6 patch] scsi_transport_spi.c: make print_nego() static Adrian Bunk
2006-01-05 22:44 ` Matthew Wilcox
@ 2006-01-07 1:26 ` Diego Calleja
1 sibling, 0 replies; 4+ messages in thread
From: Diego Calleja @ 2006-01-07 1:26 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
El Thu, 5 Jan 2006 23:39:18 +0100,
Adrian Bunk <bunk@stusta.de> escribió:
> This patch makes a needlessly global function static.
Ok, so this is probably a stupid question and it may have been already
discussed but.....
Isn't possible that GCC would/will add an extension (a useful one) similar
to the visibility thing that c++ got in GCC 4.x? It somewhat weird
that we need to mark things static, instead of the contrary (marking
as global the things you want to make global, would be much nicer since
the functions made global would be the "API")
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] scsi_transport_spi.c: make print_nego() static
@ 2006-01-14 2:09 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2006-01-14 2:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: Matthew Wilcox, James Bottomley, linux-scsi, linux-kernel
This patch makes a needlessly global function static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Matthew Wilcox <matthew@wil.cx>
---
This patch was already sent on:
- 5 Jan 2006
--- linux-2.6.15-mm1-full/drivers/scsi/scsi_transport_spi.c.old 2006-01-05 22:52:19.000000000 +0100
+++ linux-2.6.15-mm1-full/drivers/scsi/scsi_transport_spi.c 2006-01-05 22:52:28.000000000 +0100
@@ -1075,7 +1075,7 @@
/* 0x04 */ "Parallel Protocol Request"
};
-void print_nego(const unsigned char *msg, int per, int off, int width)
+static void print_nego(const unsigned char *msg, int per, int off, int width)
{
if (per) {
char buf[20];
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-01-14 2:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-05 22:39 [2.6 patch] scsi_transport_spi.c: make print_nego() static Adrian Bunk
2006-01-05 22:44 ` Matthew Wilcox
2006-01-07 1:26 ` Diego Calleja
-- strict thread matches above, loose matches on Subject: below --
2006-01-14 2:09 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox