Re: [RFC/RFT][PATCH -mm 0/5] swsusp: userland interface (rev. 2)

Pavel Machek
2006-01-06T23:59:57Z

Hi!

> > > > Perhaps it is time to get 1/4 and 3/4 into -mm? You get my signed-off
> > > > on them...
> > >
> > > OK, I'll prepare them in a while.
> >
> > Thanks.
>
> I had to remake the 3/4 a bit, as it depended on some changes to power.h
> and swsusp.c done in the 2/4. Nothing particularly invasive, basically some
> definitions go to power.h and some function headers change, but please
> have a look if the patch is still OK (appended).

Still ok :-).

> > If code is simpler, lets stick with misc. You have to obtain minor by
> > mailing device@lanana.org, see Doc*/devices.txt.
>
> OK, I'll try.

It should be easy.

> > Ok, lets keep it as it is. We can always rename file in future. [I
> > don't quite understand your reasons for movement, through. Highmem is
> > part of snapshot we need to make; it is saved in a very different way
> > than rest of memory, but that is implementation detail...]
>
> I'm seeing this a bit differently. In my view highmem is handled very much
> like devices: save_highmem() turns it "off", restore_highmem() turns it "on"
> back again, they are even called next to device_power_up/down().

Yes, I guess it is possible to view it like that, too.

BTW your "write 500MB to swap" hit mainline few hours
ago. Congratulations.

Pavel
--
Thanks, Sharp!