From: Jens Axboe <axboe@suse.de>
To: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
Cc: jesper.juhl@gmail.com, khushil.dep@help.basilica.co.uk,
viro@ftp.linux.org.uk, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bio: gcc warning fix.
Date: Fri, 6 Jan 2006 20:04:02 +0100 [thread overview]
Message-ID: <20060106190402.GS3389@suse.de> (raw)
In-Reply-To: <20060106165844.399a1d07.lcapitulino@mandriva.com.br>
On Fri, Jan 06 2006, Luiz Fernando Capitulino wrote:
>
> On Fri, 6 Jan 2006 19:48:11 +0100
> Jens Axboe <axboe@suse.de> wrote:
>
> | > having assigned a value we know that gcc's warning is wrong, idx can
> | > never *actually* be used uninitialized.
> |
> | Indeed, that's the whole point. For the original submitter, you are not
> | the first to submit this. See archives for basically the same thread as
> | this one...
>
> Al Viro got it: I just wanted to make gcc not complain. But
> 'obfuscate correct code' for it is wrong.
Yes I realize this is what you wanted to do, the warning annoys me to
(using 4.0.2 as well on one machine).
> The code is right, the patch is bad. That's it.
Indeed :-)
--
Jens Axboe
next prev parent reply other threads:[~2006-01-06 19:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 15:48 [PATCH] bio: gcc warning fix Khushil Dep
2006-01-06 18:41 ` Jesper Juhl
2006-01-06 18:48 ` Jens Axboe
2006-01-06 18:53 ` Jesper Juhl
2006-01-06 18:58 ` Luiz Fernando Capitulino
2006-01-06 19:04 ` Jens Axboe [this message]
2006-01-06 19:05 ` Jesper Juhl
2006-01-06 19:33 ` Zan Lynx
2006-01-06 19:56 ` Al Viro
2006-01-07 12:22 ` Peter Osterlund
-- strict thread matches above, loose matches on Subject: below --
2006-01-06 15:07 Luiz Fernando Capitulino
2006-01-06 15:28 ` Jens Axboe
2006-01-06 15:39 ` Al Viro
2006-01-06 22:43 ` Daniel Barkalow
2006-01-06 22:52 ` Jesper Juhl
2006-01-06 23:13 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060106190402.GS3389@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=jesper.juhl@gmail.com \
--cc=khushil.dep@help.basilica.co.uk \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox