Re: [PATCH] bio: gcc warning fix.

Jesper Juhl
2006-01-06T19:05:16Z

On 1/6/06, Luiz Fernando Capitulino <lcapitulino@mandriva.com.br> wrote:
>
> On Fri, 6 Jan 2006 19:48:11 +0100
> Jens Axboe <axboe@suse.de> wrote:
>
> | > having assigned a value we know that gcc's warning is wrong, idx can
> | > never *actually* be used uninitialized.
> |
> | Indeed, that's the whole point. For the original submitter, you are not
> | the first to submit this. See archives for basically the same thread as
> | this one...
>
> Al Viro got it: I just wanted to make gcc not complain. But
> 'obfuscate correct code' for it is wrong.
>
> The code is right, the patch is bad. That's it.
>
Yeah, but thanks for trying.
You may have been wrong in this case (and learned to verify your
patches more thoroughly), but the effort to try and review and help
improve the kernel is apreciated.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html