Re: oops pauser.

[Dave Jones <davej@redhat.com>]

On Fri, Jan 06, 2006 at 01:31:10PM +0000, Alan Cox wrote:
 > On Iau, 2006-01-05 at 15:52 -0500, Dave Jones wrote:
 > > The huge number of oopses never hit the logs.
 > > They either hit early in boot before syslog is even running, or
 > > they kill the box.
 > 
 > So you don't need a two minute delay for those because as you said it
 > froze the box

it froze *AFTER* the oops had scrolled off the top of the screen.

The sequence of events before

oops
scrolly scrolly
random crap about sleeping whilst atomic or the like
scrolly scrolly
HANG

with this patch..

oops
*pause for two minutes whilst user takes a picture/scribbles it down*
scrolly scrolly
random crap about sleeping whilst atomic or the like
scrolly scrolly
HANG

 > >  > and continuing generally will hang the box
 > >  > stopping the scroll keys being used or dmesg being used to get the data
 > >  > out. 
 > > 
 > > This is exactly the problem this patch addresses.
 > > The 'scroll keys' do not work in cases where we lock up after an oops.
 > 
 > And in those cases the 2 minute freeze is meaningless

it does if it stops the oops scrolling off the screen first long enough
to capture it.

 > > Another possibility is instantly continuing after a keypress.
 > If the input layer is running that would be sensible.

Yeah, questionable. And polling hardware won't work due to usb keyboards.

 > > If we've just oopsed, the console may have no awareness of what day it is,
 > > yet alone anything about video modes. I'm not entirely sure what you're
 > > suggesting, but it gives me the creeps. Are you talking about switching
 > > away from X back to a tty when we oops?
 > 
 > Well you could try and do that but I was more thinking that if the
 > console has been told we are in graphics mode then the 2 minute delay
 > shouldn't occur.

Hmm. I'll look into that.
Any pointers ? (I don't want to spend longer than necessary looking
in that code :-)

		Dave