public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <willy@w.ods.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.4 patch] document that gcc 4 is not supported
Date: Fri, 6 Jan 2006 22:11:15 +0100	[thread overview]
Message-ID: <20060106211115.GG7142@w.ods.org> (raw)
In-Reply-To: <20060106203727.GE12131@stusta.de>

Hi Adrian,

On Fri, Jan 06, 2006 at 09:37:27PM +0100, Adrian Bunk wrote:
> gcc 4 is not supported for compiling kernel 2.4, and I don't see any 
> compelling reason why kernel 2.4 should ever be adapted to gcc 4.
> 
> This patch documents this fact.
> 
> Without this patch, your screen is flooded with warnings and errors when
> accidentially trying to compile kernel 2.4 with gcc 4.
> 
> With this patch, the same happens, but the last lines contain the
> explanation
>   #error Sorry, your GCC is too recent for kernel 2.4

Well, why not putting this into include/linux/compiler.h instead ? It
would shout earlier and will be easier to find.

> If someone makes a patch to fix all issues with gcc 4, adding the
> removal of this #error should be the most trivial part of the patch.
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  Documentation/Changes |    2 ++
>  README                |    1 +
>  init/main.c           |    7 +++++++
>  3 files changed, 10 insertions(+)
> 
> --- linux-2.4.31-rc1-full/init/main.c.old	2005-05-30 21:20:00.000000000 +0200
> +++ linux-2.4.31-rc1-full/init/main.c	2005-05-30 21:21:19.000000000 +0200
> @@ -84,6 +84,13 @@
>  #error Sorry, your GCC is too old. It builds incorrect kernels.
>  #endif
>  
> +/*
> + * gcc >= 4 is not supported by kernel 2.4
> + */
> +#if __GNUC__ > 3
> +#error Sorry, your GCC is too recent for kernel 2.4
> +#endif
> +
>  extern char _stext, _etext;
>  extern char *linux_banner;
>  
> --- linux-2.4.31-rc1-full/README.old	2005-05-30 21:21:29.000000000 +0200
> +++ linux-2.4.31-rc1-full/README	2005-05-30 21:21:59.000000000 +0200
> @@ -152,6 +152,7 @@
>  
>   - Make sure you have gcc 2.95.3 available.  gcc 2.91.66 (egcs-1.1.2) may
>     also work but is not as safe, and *gcc 2.7.2.3 is no longer supported*.
> +   gcc 4 is *not* supported.

I would even explicitly state that gcc-3.3 and 3.4 should work in most
cases, while gcc 4 will definitely not work. It's important IMHO to
give the answers that most users will be looking for, and 3.3/3.4 are
fairly common.

>     Also remember to upgrade your binutils package (for as/ld/nm and company)
>     if necessary. For more information, refer to ./Documentation/Changes.
>  
> --- linux-2.4.31-rc1-full/Documentation/Changes.old	2005-05-30 21:22:10.000000000 +0200
> +++ linux-2.4.31-rc1-full/Documentation/Changes	2005-05-30 21:22:41.000000000 +0200
> @@ -91,6 +91,8 @@
>  You should ensure you use gcc-2.96-74 or later. gcc-2.96-54 will not build
>  the kernel correctly.
>  
> +gcc 4 is not supported.
> +

Same here.

>  In addition, please pay attention to compiler optimization.  Anything
>  greater than -O2 may not be wise.  Similarly, if you choose to use gcc-2.95.x
>  or derivatives, be sure not to use -fstrict-aliasing (which, depending on
> 

Thanks,
Willy


  reply	other threads:[~2006-01-06 21:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-06 20:37 [2.4 patch] document that gcc 4 is not supported Adrian Bunk
2006-01-06 21:11 ` Willy Tarreau [this message]
2006-01-06 21:54   ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2005-05-30 19:28 Adrian Bunk
2005-05-30 19:53 ` Mikael Pettersson
2005-05-30 20:13   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060106211115.GG7142@w.ods.org \
    --to=willy@w.ods.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox