Re: MODULE_VERSION useless? (was Re: [KJ] adding missing MODULE_* stuffs)

[Matt Domsch <Matt_Domsch@dell.com>]

On Sun, Jan 08, 2006 at 01:58:00PM -0800, Greg KH wrote:
> On Sun, Jan 08, 2006 at 06:55:16PM -0300, Carlos Manuel Duclos Vergara wrote:
> > Hi everyone,
> > 
> > I have two ideas about what to do with MODULE_VERSION:
> > 1.- Defining MODULE_VERSION = KERNEL_VERSION
> 
> No.
> 
> > 2.- Schedule it for removal in one or two more versions, and automagically use 
> > the KERNEL_VERSION as module's version.
> 
> No, just let the authors of the different drivers that want to use
> MODULE_VERSION use it (for some people it does matter, and they keep it
> up to date.)  Everyone else, just don't add it if you don't care about
> it.

DKMS (http://linux.dell.com/dkms/) uses it to tell if one version is
newer than another.  For the couple dozen modules Dell regularly cares
about, the module authors have been doing a good job of keeping
MODULE_VERSION correct, for exactly this reason.

> In short, leave it alone :)

Please!

-- 
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com