From: Greg KH <greg@kroah.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jean Delvare <khali@linux-fr.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@stusta.de>
Subject: Re: i2c/ smbus question
Date: Sun, 8 Jan 2006 19:53:23 -0800 [thread overview]
Message-ID: <20060109035323.GA2824@kroah.com> (raw)
In-Reply-To: <1136761102.30123.87.camel@localhost.localdomain>
On Mon, Jan 09, 2006 at 09:58:22AM +1100, Benjamin Herrenschmidt wrote:
> On Sun, 2006-01-08 at 11:30 +0100, Jean Delvare wrote:
>
> > The i2c_smbus_write_i2c_block_data wrapper function used to be defined,
> > but was removed in 2.6.10-rc2 together with a couple other similar
> > wrappers [1] on request by Adrian Bunk, the reason being that they had
> > no user back then. I was a bit reluctant at first, but we finally agreed
> > with Adrian to remove the functions, and to reintroduce them later if
> > they were ever needed.
>
> Argh... Adrian, sometimes I hate you ;-)
>
> > So, if you need i2c_smbus_write_i2c_block_data(), we can easily
> > resurrect it. See the patch below. I made the new version a bit faster
> > (I hope) than the original by using memcpy, please confirm it works for
> > you.
>
> Seems to work. Greg, would you mean boucing that to Linus asap (if you
> are ok with it of course) ? I have a pile of patch about to hit him via
> the powerpc merge git tree and I'll "fix" some of the mac drivers in
> there to use that wrapper, so without that patch, g5 won't build ;)
Sure, Jean, care to resend it to me, as it's now lost in my archives
somewhere :)
thanks,
greg k-h
next prev parent reply other threads:[~2006-01-09 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-07 22:36 i2c/ smbus question Benjamin Herrenschmidt
2006-01-08 10:30 ` Jean Delvare
2006-01-08 21:10 ` Benjamin Herrenschmidt
2006-01-08 22:58 ` Benjamin Herrenschmidt
2006-01-09 3:53 ` Greg KH [this message]
2006-01-09 4:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060109035323.GA2824@kroah.com \
--to=greg@kroah.com \
--cc=benh@kernel.crashing.org \
--cc=bunk@stusta.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox