public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Sebastian <sebastian_ml@gmx.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Digital Audio Extraction with ATAPI drives far from perfect
Date: Mon, 9 Jan 2006 11:03:22 +0100	[thread overview]
Message-ID: <20060109100322.GP3389@suse.de> (raw)
In-Reply-To: <20060109094923.GA8373@section_eight.mops.rwth-aachen.de>

On Mon, Jan 09 2006, Sebastian wrote:
> On Mo, Jan 09, 2006 at 10:30:25 +0100, Jens Axboe wrote:
> > Sebastian, care to try one more thing? Patch your kernel with this
> > little patch and try ripping a known "faulty" track again _not_ using
> > SG_IO. See if that produces the same faulty results again, or if it
> > actually works.
> > 
> > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> > index 1539603..2e44d81 100644
> > --- a/drivers/cdrom/cdrom.c
> > +++ b/drivers/cdrom/cdrom.c
> > @@ -426,7 +426,7 @@ int register_cdrom(struct cdrom_device_i
> >  		cdi->exit = cdrom_mrw_exit;
> >  
> >  	if (cdi->disk)
> > -		cdi->cdda_method = CDDA_BPC_FULL;
> > +		cdi->cdda_method = CDDA_BPC_SINGLE;
> >  	else
> >  		cdi->cdda_method = CDDA_OLD;
> >  
> > 
> > -- 
> > Jens Axboe
> > 
> Hi Jens,
> 
> I applied your patch, recompiled the kernel, rebooted and recompiled
> cdparanoia without the Red Hat patches. Extracting the first track of my
> test cd the result was the same as without the kernel patch with ide-cd
> using the cooked interface (md5 e8319ccc20d053557578b9ca3eb368dd).
> 
> Sorry :)

Well it's actually a good thing, because then at least it's not a bug
with the multi-frame extraction. So my guess would still be at the error
correction possibilities that the application has, in which case
CDROMREADAUDIO is just an inferior interface for this sort of thing. It
also doesn't give the issuer a chance to look at potential error
reasons, since the extended status isn't available.

-- 
Jens Axboe


  reply	other threads:[~2006-01-09 10:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-03 22:20 Digital Audio Extraction with ATAPI drives far from perfect Sebastian
2006-01-04  9:20 ` Jens Axboe
2006-01-04  9:24   ` Jens Axboe
2006-01-04 15:08     ` Mark Lord
2006-01-04 15:13       ` Jens Axboe
2006-01-04 15:50     ` Sebastian
2006-01-04 19:36       ` Alistair John Strachan
2006-01-04 21:54         ` Sebastian
2006-01-06 13:39       ` jerome lacoste
2006-01-05  6:43     ` Sebastian
2006-01-06  8:06 ` Joshua Kwan
2006-01-06 23:25   ` Sebastian
2006-01-06 23:30     ` Mark Knecht
2006-01-07 10:39       ` Sebastian
2006-01-07 10:56         ` Jens Axboe
2006-01-07 11:00           ` Jens Axboe
2006-01-07 11:53             ` Sebastian
2006-01-07 11:57               ` Jens Axboe
     [not found]           ` <20060107112443.GA18749@section_eight.mops.rwth-aachen.de>
     [not found]             ` <20060107115340.GW3389@suse.de>
     [not found]               ` <20060107115449.GB20748@section_eight.mops.rwth-aachen.de>
     [not found]                 ` <20060107115947.GY3389@suse.de>
2006-01-07 14:08                   ` Sebastian
2006-01-07 14:22                     ` Jens Axboe
2006-01-07 16:06                       ` Sebastian
2006-01-07 17:44                         ` Brad Campbell
2006-01-07 18:02                           ` Sebastian
2006-01-07 18:39                             ` Lee Revell
2006-01-07 18:45                             ` Brad Campbell
2006-01-09  9:30                               ` Jens Axboe
2006-01-09  9:49                                 ` Sebastian
2006-01-09 10:03                                   ` Jens Axboe [this message]
2006-01-10 22:43                                     ` Rene Herman
2006-01-10 22:52                                       ` Lee Revell
2006-01-10 23:05                                         ` Rene Herman
2006-01-07 17:24                       ` Sebastian
2006-01-07 19:18                     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060109100322.GP3389@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian_ml@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox