From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Vernon Mauery <vernux@us.ibm.com>
Subject: [PATCH 5/5] ibmasm: fix input initialization error path
Date: Tue, 10 Jan 2006 02:09:50 -0500 [thread overview]
Message-ID: <20060110071650.959796000.dtor_core@ameritech.net> (raw)
In-Reply-To: 20060110070945.912712000.dtor_core@ameritech.net
[-- Attachment #1: ibmasm-register-fix.patch --]
[-- Type: text/plain, Size: 805 bytes --]
Input: ibmasm - fix input initialization error path
Do not try to free device that has already been unregistered,
input_unregister_device() frees it automatically.
Spotted by Vernon Mauery <vernux@us.ibm.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/misc/ibmasm/remote.c | 1 +
1 files changed, 1 insertion(+)
Index: work/drivers/misc/ibmasm/remote.c
===================================================================
--- work.orig/drivers/misc/ibmasm/remote.c
+++ work/drivers/misc/ibmasm/remote.c
@@ -270,6 +270,7 @@ int ibmasm_init_remote_input_dev(struct
err_unregister_mouse_dev:
input_unregister_device(mouse_dev);
+ mouse_dev = NULL; /* so we don't try to free it again below */
err_free_devices:
input_free_device(mouse_dev);
input_free_device(keybd_dev);
prev parent reply other threads:[~2006-01-10 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 7:09 [PATCH 0/5] Tiny input update for 2.6.15 Dmitry Torokhov
2006-01-10 7:09 ` [PATCH 1/5] grip_mp: small cleanup Dmitry Torokhov
2006-01-10 7:09 ` [PATCH 2/5] wistron: do not crash if BIOS does not support interface Dmitry Torokhov
2006-01-10 7:09 ` [PATCH 3/5] Input core: prepare for fops constness Dmitry Torokhov
2006-01-10 7:09 ` [PATCH 4/5] Remove obsolete maple input drivers Dmitry Torokhov
2006-01-10 7:09 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110071650.959796000.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vernux@us.ibm.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox