Documentation patch.

Documentation patch.

[G.W. Haywood]

Hi folks,

This had me grepping the docs for a minute or two...

73,
Ged.
============================================================================

~/src/linux/Documentation$ > diff -C3 Configure.help Configure.help.original
*** Configure.help      Thu Dec 29 12:55:30 2005
--- Configure.help.original     Wed Dec 28 14:11:26 2005
***************
*** 12827,12834 ****
    without a specific driver are compatible with NE2000.

    If you have a PCI NE2000 card however, say N here and Y to "PCI
!   NE2000 and clones support" under "EISA, VLB, PCI and on board
!   controllers" below. If you have a NE2000 card and are running on
    an MCA system (a bus system used on some IBM PS/2 computers and
    laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
    below.
--- 12827,12833 ----
    without a specific driver are compatible with NE2000.

    If you have a PCI NE2000 card however, say N here and Y to "PCI
!   NE2000 support", above. If you have a NE2000 card and are running on
    an MCA system (a bus system used on some IBM PS/2 computers and
    laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
    below.

Re: Documentation patch.

[Erik Mouw]

On Thu, Dec 29, 2005 at 01:04:01PM +0000, G.W. Haywood wrote:
> This had me grepping the docs for a minute or two...

Thanks for your patch. Could you tell against what kernel version it is
(I guess some 2.4 kernel) and rediff it using "diff -u" (unified diffs
are so much easier to read).


Erik


-- 
+-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 --
| Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands

[PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[G.W. Haywood]

From: Ged Haywood <ged@jubileegroup.co.uk>

Improved reference to PCI ne2k support in ISA ne2k documentation.

Signed-off-by: Ged Haywood <ged@jubileegroup.co.uk>
---
 Configure.help |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.4.32/Documentation/Configure.help.original  2006-01-07 14:48:23.000000000 +0000
+++ linux-2.4.32/Documentation/Configure.help   2006-01-07 14:56:32.000000000 +0000
@@ -12778,7 +12778,8 @@
   without a specific driver are compatible with NE2000.

   If you have a PCI NE2000 card however, say N here and Y to "PCI
-  NE2000 support", above. If you have a NE2000 card and are running on
+  NE2000 and clones support" under "EISA, VLB, PCI and on board
+  controllers" below.  If you have a NE2000 card and are running on
   an MCA system (a bus system used on some IBM PS/2 computers and
   laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
   below.

[PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[G.W. Haywood]

From: Ged Haywood <ged@jubileegroup.co.uk>

Improved reference to PCI ne2k support in ISA ne2k documentation.

Signed-off-by: Ged Haywood <ged@jubileegroup.co.uk>
---

 drivers/net/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.15-rc7-git3-orig/drivers/net/Kconfig      2005-12-29 21:15:54.000000000 +0100
+++ linux-2.6.15-rc7-git3/drivers/net/Kconfig   2005-12-29 21:33:26.000000000 +0100
@@ -1076,7 +1076,8 @@
          without a specific driver are compatible with NE2000.

          If you have a PCI NE2000 card however, say N here and Y to "PCI
-         NE2000 support", above. If you have a NE2000 card and are running on
+         NE2000 and clone support" under "EISA, VLB, PCI and on board
+         controllers" below. If you have a NE2000 card and are running on
          an MCA system (a bus system used on some IBM PS/2 computers and
          laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
          below.

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[Marcelo Tosatti]

On Sat, Jan 07, 2006 at 03:11:40PM +0000, G.W. Haywood wrote:
> From: Ged Haywood <ged@jubileegroup.co.uk>
> 
> Improved reference to PCI ne2k support in ISA ne2k documentation.
> 
> Signed-off-by: Ged Haywood <ged@jubileegroup.co.uk>
> ---
>  Configure.help |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> --- linux-2.4.32/Documentation/Configure.help.original  2006-01-07 14:48:23.000000000 +0000
> +++ linux-2.4.32/Documentation/Configure.help   2006-01-07 14:56:32.000000000 +0000
> @@ -12778,7 +12778,8 @@
>    without a specific driver are compatible with NE2000.
> 
>    If you have a PCI NE2000 card however, say N here and Y to "PCI
> -  NE2000 support", above. If you have a NE2000 card and are running on
> +  NE2000 and clones support" under "EISA, VLB, PCI and on board
> +  controllers" below.  If you have a NE2000 card and are running on
>    an MCA system (a bus system used on some IBM PS/2 computers and
>    laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
>    below.

Hi Ged,

Appreciate your efforts but the v2.4 tree is under deep maintenance mode
with an acceptance criteria for critical bugfixes only.

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[Jeff Garzik]

G.W. Haywood wrote:
> From: Ged Haywood <ged@jubileegroup.co.uk>
> 
> Improved reference to PCI ne2k support in ISA ne2k documentation.
> 
> Signed-off-by: Ged Haywood <ged@jubileegroup.co.uk>
> ---
> 
>  drivers/net/Kconfig |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletion(-)

patch OK, but does not apply:


Applying 'ne2k PCI/ISA documentation: improved cross-reference.'

fatal: corrupt patch at line 10

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[Marcelo Tosatti]

On Mon, Jan 09, 2006 at 04:46:09PM +0000, G.W. Haywood wrote:
> Hi Marcelo,
> 
> On Mon, 9 Jan 2006, Marcelo Tosatti wrote:
> 
> > On Sat, Jan 07, 2006 at 03:11:40PM +0000, G.W. Haywood wrote:
> > > From: Ged Haywood <ged@jubileegroup.co.uk>
> > >
> > > Improved reference to PCI ne2k support in ISA ne2k documentation.
> 
> > Appreciate your efforts but the v2.4 tree is under deep maintenance mode
> 
> Sorry, I didn't know.  (And evidently several other people on the LKML
> didn't know either... :)  Does that mean that development is finished
> on the 2.4 tree, or will it switch back to accepting patches at some
> future time?  

Development is definately finished. The maintenance of the stable tree 
at this point should be done to fix critical problems.

So, its accepting patches, but only for critical problems/real bugs.

> There's quite a lot in the Documentation/ directory that could be
> improved (as you probably know:).

Definately - the community has concentrated efforts on the v2.6 tree
for more than 3, 4 years.

linux-2.6.14/drivers/net/Kconfig has the exact same text: 

    If you have a PCI NE2000 card however, say N here and Y to "PCI
    NE2000 support", above. If you have a NE2000 card and are running on
    an MCA system (a bus system used on some IBM PS/2 computers and
    laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
    below.

Send a patch :)

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[G.W. Haywood]

Hi Marcelo,

On Mon, 9 Jan 2006, Marcelo Tosatti wrote:

> On Sat, Jan 07, 2006 at 03:11:40PM +0000, G.W. Haywood wrote:
> > From: Ged Haywood <ged@jubileegroup.co.uk>
> >
> > Improved reference to PCI ne2k support in ISA ne2k documentation.

> Appreciate your efforts but the v2.4 tree is under deep maintenance mode

Sorry, I didn't know.  (And evidently several other people on the LKML
didn't know either... :)  Does that mean that development is finished
on the 2.4 tree, or will it switch back to accepting patches at some
future time?  There's quite a lot in the Documentation/ directory that
could be improved (as you probably know:).

73,
Ged.

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[Adrian Bunk]

On Mon, Jan 09, 2006 at 11:06:55AM -0200, Marcelo Tosatti wrote:
> On Sat, Jan 07, 2006 at 03:11:40PM +0000, G.W. Haywood wrote:
> > From: Ged Haywood <ged@jubileegroup.co.uk>
> > 
> > Improved reference to PCI ne2k support in ISA ne2k documentation.
> > 
> > Signed-off-by: Ged Haywood <ged@jubileegroup.co.uk>
> > ---
> >  Configure.help |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > --- linux-2.4.32/Documentation/Configure.help.original  2006-01-07 14:48:23.000000000 +0000
> > +++ linux-2.4.32/Documentation/Configure.help   2006-01-07 14:56:32.000000000 +0000
> > @@ -12778,7 +12778,8 @@
> >    without a specific driver are compatible with NE2000.
> > 
> >    If you have a PCI NE2000 card however, say N here and Y to "PCI
> > -  NE2000 support", above. If you have a NE2000 card and are running on
> > +  NE2000 and clones support" under "EISA, VLB, PCI and on board
> > +  controllers" below.  If you have a NE2000 card and are running on
> >    an MCA system (a bus system used on some IBM PS/2 computers and
> >    laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
> >    below.
> 
> Hi Ged,
> 
> Appreciate your efforts but the v2.4 tree is under deep maintenance mode
> with an acceptance criteria for critical bugfixes only.

Wouldn't it make sense to make an exception from this rule for 
documentation updates?

Documentation updates can't do much harm.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[Jesper Juhl]

On 1/9/06, Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
> On Mon, Jan 09, 2006 at 04:46:09PM +0000, G.W. Haywood wrote:
> > Hi Marcelo,
> >
> > On Mon, 9 Jan 2006, Marcelo Tosatti wrote:
> >
> > > On Sat, Jan 07, 2006 at 03:11:40PM +0000, G.W. Haywood wrote:
> > > > From: Ged Haywood <ged@jubileegroup.co.uk>
> > > >
> > > > Improved reference to PCI ne2k support in ISA ne2k documentation.
> >
> > > Appreciate your efforts but the v2.4 tree is under deep maintenance mode
> >
> > Sorry, I didn't know.  (And evidently several other people on the LKML
> > didn't know either... :)  Does that mean that development is finished
> > on the 2.4 tree, or will it switch back to accepting patches at some
> > future time?
>
> Development is definately finished. The maintenance of the stable tree
> at this point should be done to fix critical problems.
>
> So, its accepting patches, but only for critical problems/real bugs.
>
> > There's quite a lot in the Documentation/ directory that could be
> > improved (as you probably know:).
>
> Definately - the community has concentrated efforts on the v2.6 tree
> for more than 3, 4 years.
>
> linux-2.6.14/drivers/net/Kconfig has the exact same text:
>
>     If you have a PCI NE2000 card however, say N here and Y to "PCI
>     NE2000 support", above. If you have a NE2000 card and are running on
>     an MCA system (a bus system used on some IBM PS/2 computers and
>     laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
>     below.
>
> Send a patch :)
>
Mr. Haywood already did (to LKML).
I created a 2.6 version of his patch and he submitted it to LKML -
it's not been picked up yet though.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] ne2k PCI/ISA documentation: improved cross-reference.

[Marcelo Tosatti]

On Tue, Jan 10, 2006 at 01:42:35PM +0100, Adrian Bunk wrote:
> On Mon, Jan 09, 2006 at 11:06:55AM -0200, Marcelo Tosatti wrote:
> > On Sat, Jan 07, 2006 at 03:11:40PM +0000, G.W. Haywood wrote:
> > > From: Ged Haywood <ged@jubileegroup.co.uk>
> > > 
> > > Improved reference to PCI ne2k support in ISA ne2k documentation.
> > > 
> > > Signed-off-by: Ged Haywood <ged@jubileegroup.co.uk>
> > > ---
> > >  Configure.help |    3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > --- linux-2.4.32/Documentation/Configure.help.original  2006-01-07 14:48:23.000000000 +0000
> > > +++ linux-2.4.32/Documentation/Configure.help   2006-01-07 14:56:32.000000000 +0000
> > > @@ -12778,7 +12778,8 @@
> > >    without a specific driver are compatible with NE2000.
> > > 
> > >    If you have a PCI NE2000 card however, say N here and Y to "PCI
> > > -  NE2000 support", above. If you have a NE2000 card and are running on
> > > +  NE2000 and clones support" under "EISA, VLB, PCI and on board
> > > +  controllers" below.  If you have a NE2000 card and are running on
> > >    an MCA system (a bus system used on some IBM PS/2 computers and
> > >    laptops), say N here and Y to "NE/2 (ne2000 MCA version) support",
> > >    below.
> > 
> > Hi Ged,
> > 
> > Appreciate your efforts but the v2.4 tree is under deep maintenance mode
> > with an acceptance criteria for critical bugfixes only.
> 
> Wouldn't it make sense to make an exception from this rule for 
> documentation updates?
> 
> Documentation updates can't do much harm.

Hi Adrian,

That would open precedence on "exceptions" - one could argue that
different classes of updates can't do much harm either.

The maintenance process should concentrate on problems which can affect
installations running legacy v2.4.

Another point in favour of restricting updates on the v2.4 tree are
external patches. There are a bunch of them being cultivated by the
community. For them, the less changes in mainline, the better.