public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
To: Keith Owens <kaos@sgi.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>,
	Paulo Marques <pmarques@grupopie.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	akpm@osdl.org, tony.luck@intel.com,
	Systemtap <systemtap@sources.redhat.com>,
	Jim Keniston <jkenisto@us.ibm.com>
Subject: Re: [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres
Date: Tue, 10 Jan 2006 16:39:57 -0800	[thread overview]
Message-ID: <20060110163956.A17329@unix-os.sc.intel.com> (raw)
In-Reply-To: <20396.1136939008@ocs3.ocs.com.au>; from kaos@sgi.com on Wed, Jan 11, 2006 at 11:23:28AM +1100

On Wed, Jan 11, 2006 at 11:23:28AM +1100, Keith Owens wrote:
> "Randy.Dunlap" (on Tue, 10 Jan 2006 16:07:55 -0800 (PST)) wrote:
> >On Wed, 11 Jan 2006, Keith Owens wrote:
> >> Changing the thread slightly, kallsyms_lookup_name() has never coped
> >> with duplicate local symbols and it cannot do so without changing its
> >> API, and all its callers.  For debugging purposes, it would be nicer if
> >> the kernel did not have any duplicate symbols.  Perhaps some kernel
> >> janitor would like to take that task on.
> >
> >Jesper Juhl was doing some -Wshadow patches.  Would that detect
> >duplicate symbols?
> 
> No, the duplicate symbols are (a) static and (b) in separate source
> files.  Run this against a System.map.
> 
>  awk '{print $NF}' System.map | egrep -v '^__ks|^__func' | sort | uniq -dc | LANG=C sort -k2

Humm..This duplication of symbols in the kernel will be a 
problem for systemtap scripts, as we might end up putting probes
in the unwanted places :-(

I agree with you Keith, from the debugging purposes, it 
would make sense not to have any duplicate symbols.

Thanks,
Anil


  reply	other threads:[~2006-01-11  0:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-10 20:39 kallsyms_lookup_name should return the text addres Anil S Keshavamurthy
2006-01-10 20:39 ` [patch 1/2] [BUG]kallsyms_lookup_name " Anil S Keshavamurthy
2006-01-10 20:45   ` Paulo Marques
2006-01-10 21:07     ` Keshavamurthy Anil S
2006-01-10 23:11       ` Keith Owens
2006-01-10 23:29         ` Keshavamurthy Anil S
2006-01-11  0:02           ` Keith Owens
2006-01-11  0:07             ` Randy.Dunlap
2006-01-11  0:23               ` Keith Owens
2006-01-11  0:39                 ` Keshavamurthy Anil S [this message]
2006-01-11  2:26                   ` Frank Ch. Eigler
2006-01-10 20:39 ` [patch 2/2] Link new module to the tail of module list Anil S Keshavamurthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060110163956.A17329@unix-os.sc.intel.com \
    --to=anil.s.keshavamurthy@intel.com \
    --cc=akpm@osdl.org \
    --cc=jkenisto@us.ibm.com \
    --cc=kaos@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmarques@grupopie.com \
    --cc=rdunlap@xenotime.net \
    --cc=systemtap@sources.redhat.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox