From: Dipankar Sarma <dipankar@in.ibm.com>
To: "Paul E. McKenney" <paulmck@us.ibm.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org,
Manfred Spraul <manfred@colorfullife.com>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 4/5] rcu: join rcu_ctrlblk and rcu_state
Date: Tue, 10 Jan 2006 23:39:54 +0530 [thread overview]
Message-ID: <20060110180954.GA5387@in.ibm.com> (raw)
In-Reply-To: <20060110002818.GD15083@us.ibm.com>
On Mon, Jan 09, 2006 at 04:28:18PM -0800, Paul E. McKenney wrote:
> On Sun, Jan 08, 2006 at 10:19:42PM +0300, Oleg Nesterov wrote:
> > This patch moves rcu_state into the rcu_ctrlblk. I think there
> > are no reasons why we should have 2 different variables to control
> > rcu state. Every user of rcu_state has also "rcu_ctrlblk *rcp" in
> > the parameter list.
>
> This patch looks sane to me. It passes a short one-hour rcutorture
> on ppc64 and x86, firing up some overnight runs as well.
>
> Dipankar, Manfred, any other concerns? Cacheline alignment? (Seems
> to me this code is far enough from the fastpath that this should not
> be a problem, but thought I should ask.)
>
rcu_state came over from Manfred's RCU_HUGE patch IIRC. I don't
think it is necessary to allocate rcu_state separately in the
current mainline RCU code. So, the patch looks OK to me, but
Manfred might see something that I am not seeing.
Thanks
Dipankar
next prev parent reply other threads:[~2006-01-10 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 19:19 [PATCH 4/5] rcu: join rcu_ctrlblk and rcu_state Oleg Nesterov
2006-01-10 0:28 ` Paul E. McKenney
2006-01-10 0:43 ` Linus Torvalds
2006-01-10 2:54 ` Paul E. McKenney
2006-01-10 10:02 ` Srivatsa Vaddagiri
2006-01-10 18:09 ` Dipankar Sarma [this message]
2006-01-10 20:44 ` Manfred Spraul
2006-01-10 21:51 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110180954.GA5387@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=oleg@tv-sign.ru \
--cc=paulmck@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox