public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Eric Sandeen <sandeen@sgi.com>,
	hch@infradead.org, linux-kernel@vger.kernel.org,
	linux-xfs@oss.sgi.com
Subject: Re: xfs: Makefile-linux-2.6 => Makefile?
Date: Tue, 10 Jan 2006 21:00:54 +0100	[thread overview]
Message-ID: <20060110200054.GA14721@mars.ravnborg.org> (raw)
In-Reply-To: <20060109234532.78bda36a.akpm@osdl.org>

On Mon, Jan 09, 2006 at 11:45:32PM -0800, Andrew Morton wrote:
> 
> It'd be nice to fix this:
> 
> bix:/usr/src/25> make fs/xfs/linux-2.6/xfs_iops.o
>   SPLIT   include/linux/autoconf.h -> include/config/*
>   SHIPPED scripts/genksyms/lex.c
>   SHIPPED scripts/genksyms/parse.h
>   SHIPPED scripts/genksyms/keywords.c
>   HOSTCC  scripts/genksyms/lex.o
>   SHIPPED scripts/genksyms/parse.c
>   HOSTCC  scripts/genksyms/parse.o
>   HOSTLD  scripts/genksyms/genksyms
>   HOSTCC  scripts/mod/file2alias.o
>   HOSTCC  scripts/mod/modpost.o
>   HOSTLD  scripts/mod/modpost
> scripts/Makefile.build:15: /usr/src/devel/fs/xfs/linux-2.6/Makefile: No such file or directory
> make[1]: *** No rule to make target `/usr/src/devel/fs/xfs/linux-2.6/Makefile'.  Stop.
> make: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 2

xfs as one of the very few users in the kernel has split up .o files in
several directories. And kbuild does not have support for specifying
that is shall link to a .o file that is being build in a sub-directory.

This is in general noe encouraged for the kernel - it is not common
practice. And therefore not something I have planned to implement.

If there is a general consensus that we like to have this then it is
doable, but it will uglify scripts/Makefile.lib even more.

For xfs this is 37 .o files that are build in three directories.
The easy fix would be to move the files to stay just under the xfs/
directory like all others - but xfs people prefer not to do so to stay
compatible with their external source tree.

	Sam

      parent reply	other threads:[~2006-01-10 20:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-09 16:42 xfs: Makefile-linux-2.6 => Makefile? Sam Ravnborg
2006-01-09 16:46 ` Christoph Hellwig
2006-01-09 17:19   ` Sam Ravnborg
2006-01-09 21:01   ` Sam Ravnborg
2006-01-09 21:05     ` Christoph Hellwig
2006-01-09 21:18       ` Sam Ravnborg
2006-01-09 21:03   ` Eric Sandeen
2006-01-09 21:20     ` Sam Ravnborg
2006-01-09 21:23       ` Eric Sandeen
2006-01-09 21:45         ` Sam Ravnborg
2006-01-10  7:45     ` Andrew Morton
2006-01-10 15:14       ` Eric Sandeen
2006-01-10 16:34       ` Eric Sandeen
2006-01-10 20:02         ` Sam Ravnborg
2006-01-16 23:19         ` Sam Ravnborg
2006-01-17  3:40           ` Eric Sandeen
2006-01-10 20:00       ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060110200054.GA14721@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=sandeen@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox