From: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>, akpm@osdl.org
Cc: tony.luck@intel.com, "Systemtap" <systemtap@sources.redhat.com>,
"Jim Keniston" <jkenisto@us.ibm.com>,
"Keith Owens" <kaos@sgi.com>
Subject: kallsyms_lookup_name should return the text addres
Date: Tue, 10 Jan 2006 12:39:12 -0800 [thread overview]
Message-ID: <20060110203912.007577046@csdlinux-2.jf.intel.com> (raw)
On architectures like IA64, kallsyms_lookup_name(name) returns
the actual text address corresponding to the "name" and sometimes
returns address of the function descriptor, the behavior is
not consistent.
The bug is kallsyms_lookup_name() -> module_kallsyms_lookup_name(mod, name)
search the name in the given module and returns the address when
name is matched. This address very well could be the address of 'U' type
which is different address than 't' type.
Example:
Here is the output of cat /proc/kallsyms when we have test1.ko using the
my_test_reentrant_export_function.
-----------------------------------------------------------------
a00000020008c090 U my_test_reentrant_export_function [test1]
a00000020008c0a0 r __ksymtab_my_test_reentrant_export_function [mon_dummy]
a00000020008c0b0 r __kstrtab_my_test_reentrant_export_function [mon_dummy]
a00000020008c0d8 r __kcrctab_my_test_reentrant_export_function [mon_dummy]
00000000a356bab8 a __crc_my_test_reentrant_export_function [mon_dummy]
a00000020008c000 T my_test_reentrant_export_function [mon_dummy]
---------------------------------------------------------------
When we have test1.ko loaded,
kallsyms_lookup_name(my_test_reentrant_export_function)
returns 0xa00000020008c090 which is a function descriptor address and
when test1.ko is removed
kallsyms_lookup_name(my_test_reentrant_export_function)
returns 0xa00000020008c000 which is the actual text address
The patch following this mail fixes this issue.
-Anil Keshavamurthy
next reply other threads:[~2006-01-10 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 20:39 Anil S Keshavamurthy [this message]
2006-01-10 20:39 ` [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres Anil S Keshavamurthy
2006-01-10 20:45 ` Paulo Marques
2006-01-10 21:07 ` Keshavamurthy Anil S
2006-01-10 23:11 ` Keith Owens
2006-01-10 23:29 ` Keshavamurthy Anil S
2006-01-11 0:02 ` Keith Owens
2006-01-11 0:07 ` Randy.Dunlap
2006-01-11 0:23 ` Keith Owens
2006-01-11 0:39 ` Keshavamurthy Anil S
2006-01-11 2:26 ` Frank Ch. Eigler
2006-01-10 20:39 ` [patch 2/2] Link new module to the tail of module list Anil S Keshavamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060110203912.007577046@csdlinux-2.jf.intel.com \
--to=anil.s.keshavamurthy@intel.com \
--cc=akpm@osdl.org \
--cc=jkenisto@us.ibm.com \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=systemtap@sources.redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox