Re: Revised [PATCH] Documentation: Update to SubmittingPatches

[Adrian Bunk <bunk@stusta.de>]

On Tue, Jan 10, 2006 at 08:38:23PM -0500, Sean wrote:
> On Tue, January 10, 2006 7:57 pm, Adrian Bunk said:
> 
> >> -Use "diff -up" or "diff -uprN" to create patches.
> >> +You can use git-diff(1) or git-format-patch(1) which makes your life
> >> easy. If
> >> +you want it to be more difficult then carry on reading.
> >>...
> >
> > IMHO, this doesn't make much sense:
> >
> > The average patch submitter does _not_ use git in any way - and there's
> > no reason why he should.
> >
> 
> Git is an efficient and convenient way to track the mainline kernel.   The
> number of submitters using it is significant enough to mention it as an
> option for creating patches.


<--  snip  -->

--------------------------------------------
SECTION 1 - CREATING AND SENDING YOUR CHANGE
--------------------------------------------

1) Creating a diff file
-----------------------

You can use git-diff(1) or git-format-patch(1) which makes your life easy. If
you want it to be more difficult then carry on reading.

<--  snip  -->


The first mentionings of the string "git" in the document are in this 
line.

SubmittingPatches should teach newbies how to create good patches with 
GNU diff, and random references to git programs don't help anyone.

If a submitter is using a git-based workflow he most likely has a 
comletely different wotkflow than the one described in SubmittingPatches -
and git-specific documents should cover what he should do.


> Sean

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed